Skip to content

ci: use node version 20 in tests #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

ci: use node version 20 in tests #3101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aba1e8
ci: use node version 20 in tests
mrstork Sep 4, 2025
353e096
ci: cache busting test fixtures
mrstork Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deno-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: 'Install Node'
uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: 'Install Node'
uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- uses: oven-sh/setup-bun@v2
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
- name: 'Install Node'
uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- name: Prefer npm global on windows
Expand Down Expand Up @@ -208,7 +208,7 @@ jobs:
- name: 'Install Node'
uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- name: setup pnpm/yarn
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/size-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: '20.x'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ concurrency:
cancel-in-progress: true

env:
NODE_VERSION: 18.18.0
NODE_VERSION: 20.9.0
PNPM_VERSION: 8.9.0
NEXT_REPO: vercel/next.js
NEXT_TEST_MODE: deploy
Expand Down
2 changes: 1 addition & 1 deletion tests/prepare.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const e2eOnlyFixtures = new Set([
'middleware-node-runtime-specific',
'middleware-static-asset-matcher',
'middleware-subrequest-vuln',
// There is also a bug on Windows on Node.js 18.20.6, that cause build failures on this fixture
// There is a bug on Windows on Node.js 18.20.6, that causes build failures on this fixture
// see https://github.com/opennextjs/opennextjs-netlify/actions/runs/13268839161/job/37043172448?pr=2749#step:12:78
'middleware-og',
'middleware-single-matcher',
Expand Down
Loading