fix: don't move files to the CDN if they match redirect/rewrite rules #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
changed the title
Release-As: 4.0.0-beta.10
ascorbic
force-pushed
the
mk/rewrite-static
branch
from
a86ab58 to
aa17745
Compare
tiffafoo
reviewed
Nov 24, 2021
| @@ -1,4 +1,4 @@ | |||
| // @ts-check | |||
| /* eslint-disable max-lines */ | |||
There was a problem hiding this comment.
[sand] We should probably avoid disabling eslint and separate this file into smaller ones moving forward
tiffafoo
reviewed
Nov 24, 2021
| exports.matchMiddleware = matchMiddleware | ||
| exports.stripLocale = stripLocale | ||
| exports.isDynamicRoute = isDynamicRoute | ||
|
|
||
| // eslint-disable-next-line max-lines-per-function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that if a file would match a redirect or
beforeFilesrewrite, it isn;t served from the CDN as that would prevent the rule from being applied. We could potentially be smarter and check if we can represent the rule using Netlify redirects, but that would be quite complicated to achieve and wouldn't work for lots of scenariosTest plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #819