Skip to content

Conversation

DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented Oct 19, 2023

Changelog

Add intersection component

Issue ticket number and link

Closes #519

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont linked an issue Oct 19, 2023 that may be closed by this pull request
@DriesSchaumont DriesSchaumont marked this pull request as ready for review October 19, 2023 09:30
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added a separate test with some real data, just in case.

@rcannood rcannood merged commit f1b9449 into main Nov 24, 2023
@rcannood rcannood deleted the 519-gexfb-intersection-module branch November 24, 2023 04:38
VladimirShitov pushed a commit that referenced this pull request Mar 12, 2024
* Add intersection component

* Update resource labels

* Rename and add CHANGELOG entry

* Actually rename component

* Clean up yaml

* fill in par

* add test with real data

---------

Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GEX/FB intersection module
2 participants