Skip to content

Conversation

DriesSchaumont
Copy link
Member

Changelog

Add extra test utilities, logging and asserters

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I like reusable code!

@DriesSchaumont DriesSchaumont marked this pull request as ready for review February 12, 2024 19:40
@DriesSchaumont DriesSchaumont force-pushed the extra_logging_and_test_utilities branch from 8634b78 to 571f8da Compare February 21, 2024 15:09
@rcannood
Copy link
Contributor

Tell me when! 😊

@DriesSchaumont
Copy link
Member Author

Tell me when! 😊

When!

Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@DriesSchaumont DriesSchaumont merged commit 5f22659 into main Feb 22, 2024
@DriesSchaumont DriesSchaumont deleted the extra_logging_and_test_utilities branch February 22, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants