Skip to content

Conversation

rcannood
Copy link
Contributor

While we still can

Changelog

... Describe your changes ...

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

.functionality.arguments[.multiple == true].multiple_sep := ";"
.functionality.argument_groups[true].arguments[.multiple == true].multiple_sep := ";"
.platforms[.type == 'docker'].namespace_separator := '_'
.platforms[.type == 'docker'].namespace_separator := '/'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we could just remove the entry altogether

Suggested change
.platforms[.type == 'docker'].namespace_separator := '/'

@DriesSchaumont DriesSchaumont merged commit d879fe3 into main Mar 15, 2024
@DriesSchaumont DriesSchaumont deleted the change-namespace-separator branch March 15, 2024 08:24
dorien-er pushed a commit that referenced this pull request Mar 19, 2024
* Change namespace separator for OpenPipelines v1

While we still can

* Remove newline

* Update CHANGELOG

* Trigger ci [ci force]

---------

Co-authored-by: DriesSchaumont <5946712+DriesSchaumont@users.noreply.github.com>
dorien-er pushed a commit that referenced this pull request Mar 20, 2024
* Change namespace separator for OpenPipelines v1

While we still can

* Remove newline

* Update CHANGELOG

* Trigger ci [ci force]

---------

Co-authored-by: DriesSchaumont <5946712+DriesSchaumont@users.noreply.github.com>
dorien-er pushed a commit that referenced this pull request Apr 25, 2024
* Change namespace separator for OpenPipelines v1

While we still can

* Remove newline

* Update CHANGELOG

* Trigger ci [ci force]

---------

Co-authored-by: DriesSchaumont <5946712+DriesSchaumont@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants