Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configury: do look for sed #1357

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

ggouaillardet
Copy link
Contributor

Refs. open-mpi/ompi#10392

Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp

@rhc54
Copy link
Contributor

rhc54 commented May 17, 2022

bot:ibm:xl:retest

1 similar comment
@jjhursey
Copy link
Member

bot:ibm:xl:retest

@jjhursey
Copy link
Member

The XL failure is unrelated to this change, but it is concerning that it is the prte daemons are not coming up as they should in the XL build scenario. I'll need to investigate.

bot:ibm:xl:retest

@rhc54
Copy link
Contributor

rhc54 commented May 17, 2022

I agree it is hard to understand how this change impacts the XL DVM, yet we've had no prior problems in that area. True head scratcher. Thanks for looking into it.

@rhc54
Copy link
Contributor

rhc54 commented May 18, 2022

This is very odd - other PRs are passing CI. Let's try it again.

bot:ibm:xl:retest

Refs. open-mpi/ompi#10392

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
Copy link
Contributor Author

It was pointed to me that the configure output is indeed more beautiful/intuitive if we move the sed test a bit down in configure.ac. I updated this PR accordingly.

@jjhursey
Copy link
Member

bot:ibm:xl:retest

@rhc54 rhc54 merged commit db194bb into openpmix:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants