Fix a few bugs/leaks in the OOB subsystem #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly identify the type of data being stored when storing a returned daemon URI. Don't go looking for a URI if we are terminating - if we don't know how to talk to someone, this is not the time to create new connections. Ensure we properly record the peer when it connects to us. Signed-off-by: Ralph Castain <rhc@pmix.org>
|
@abouteiller This fixed some problems I found in the messaging system. We obviously need to scrub that code to reduce its complexity - there is only one component, and a lot of that code is no longer relevant. I didn't want to touch it right now as I know you are working down there. One of the bugs would have precluded the ability to connect to a daemon that hadn't already connected to us - you might want to see if that fixes the behavior concerning you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly identify the type of data being stored when
storing a returned daemon URI. Don't go looking for
a URI if we are terminating - if we don't know how to
talk to someone, this is not the time to create new
connections. Ensure we properly record the peer when
it connects to us.
Signed-off-by: Ralph Castain rhc@pmix.org