Fixed all cheat code

[pevers]

Polished #7505 to activate all cheat codes on call and reset all on call.

[Unit158]

👎 This now limits the /all cheat to Developer Mode cheats.

On 2015-02-19, at 7:34 PM, Peter Evers notifications@github.com wrote:

Polished #7505 to activate all cheat codes on call and reset all on call.

You can view, comment on, or merge this pull request online at:

#7507

Commit Summary

changed all cheat to really enable everything on call
File Changes

M OpenRA.Game/Traits/Player/DeveloperMode.cs (31)
M OpenRA.Mods.Common/Commands/DevCommands.cs (9)
Patch Links:

https://github.com/OpenRA/OpenRA/pull/7507.patch
https://github.com/OpenRA/OpenRA/pull/7507.diff
�
Reply to this email directly or view it on GitHub.

[Unit158]

Actually, that could be fixed in other ways. You need to make sure that all the effects from the cheats that it previously activated are still activated, however.

On 2015-02-19, at 7:34 PM, Peter Evers notifications@github.com wrote:

Polished #7505 to activate all cheat codes on call and reset all on call.

You can view, comment on, or merge this pull request online at:

#7507

Commit Summary

changed all cheat to really enable everything on call
File Changes

M OpenRA.Game/Traits/Player/DeveloperMode.cs (31)
M OpenRA.Mods.Common/Commands/DevCommands.cs (9)
Patch Links:

https://github.com/OpenRA/OpenRA/pull/7507.patch
https://github.com/OpenRA/OpenRA/pull/7507.diff
�
Reply to this email directly or view it on GitHub.

[pevers]

I think I don't fully understand. Are there other modes? Future modes may have total different behaviour for disabling/enabling all cheat codes, right? So is DeveloperMode specific code a problem?

[pchote]

This looks like a good idea, but I haven't tested it yet. #7505 has always annoyed me.

[Unit158]

Disregard my first comment; I misunderstood the code. My problem is that /all doesn't currently activate the effect of DevGiveCash or DevLevelUp. I just like having the extra cash after calling /all. In any case, +1

On 2015-02-20, at 5:31 AM, Peter Evers notifications@github.com wrote:

I think I don't fully understand. Are there other modes? Future modes may have total different behaviour for disabling/enabling all cheat codes, right? So is DeveloperMode specific code a problem?

�
Reply to this email directly or view it on GitHub.

[pevers]

I could add DevGiveCash and DevLevelUp too? I wasn't totally sure if I should add this or not.

[pchote]

DevLevelUp doesn't make a lot of sense for this, since it requires you to have actors selected.

[obrakmann]

👍 once DevGiveCash has been added

[penev92]

I'd say give something like 100k cash in order to simplify things (just hardcode it) and squash the commits.

[phrohdoh]

Let's not hardcode it.
It already has a default value.

[pevers]

The commits are now squashed.

[obrakmann]

Thanks!

Changelog

[Mailaender]

The shroud is not disabled anymore when I type /all.

[pevers]

Oops, I missed that. Sorry, I'll open a PR.