Skip to content

Fix: TrainCarOperations doesn't work as expected after resume. #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix: TrainCarOperations doesn't work as expected after resume. #1008

merged 1 commit into from
Dec 18, 2024
+5 −1

Conversation

mbm-OR
Copy link
Contributor

@mbm-OR mbm-OR commented Dec 3, 2024

The TrainCarOperations windows is not working as expected after resume.
More info here, Bug #2090952.

@mbm-OR mbm-OR added the bug Something isn't working label Dec 3, 2024
@mbm-OR mbm-OR self-assigned this Dec 3, 2024
twpol pushed a commit that referenced this pull request Dec 3, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 10 pull requests
f250851 
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 838c314: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 3, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 11 pull requests
77a948e 
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 838c314: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 3, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 12 pull requests
464604f 
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 838c314: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 4, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 12 pull requests
55f6b43 
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at db032e7: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 5, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 12 pull requests
803f93b 
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 801ad4a: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 6, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 13 pull requests
8e1cde4 
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1011 at eb030f8: adds INI File to Appendix
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 801ad4a: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 7, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 13 pull requests
e648ea4 
- Pull request #891 at 9ab9994: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1011 at eb030f8: adds INI File to Appendix
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 801ad4a: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 7, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 13 pull requests
f278f00 
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1011 at eb030f8: adds INI File to Appendix
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 801ad4a: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1001 at fe770dc: Telemetry collection and menu options #or-telemetry-system
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 7, 2024
@openrails-bot
Automatic merge of T1.5.1-1417-g99a47c9c6 and 13 pull requests
3f68597 
- Pull request #891 at 488135e: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1011 at eb030f8: adds INI File to Appendix
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 801ad4a: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 12, 2024
@openrails-bot
Automatic merge of T1.5.1-1427-gcc88c4390 and 12 pull requests
51de28f 
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1011 at b762b1a: adds INI File to Appendix
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at 801ad4a: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 13, 2024
@openrails-bot
Automatic merge of T1.5.1-1430-g3fb566e8b and 11 pull requests
98df11a 
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 15, 2024
@openrails-bot
Automatic merge of T1.5.1-1430-g3fb566e8b and 12 pull requests
5d233d7 
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1012 at fbb87b0: doc:adds 3 news items to Manual
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 16, 2024
@openrails-bot
Automatic merge of T1.5.1-1430-g3fb566e8b and 12 pull requests
b47fff6 
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1012 at fbb87b0: doc:adds 3 news items to Manual
- Pull request #1014 at ca9f457: Bug fix for https://bugs.launchpad.net/or/+bug/2091895 Train disappears from train list window
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
twpol pushed a commit that referenced this pull request Dec 18, 2024
@openrails-bot
Automatic merge of T1.5.1-1430-g3fb566e8b and 13 pull requests
62ec256 
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 8a9c8f9: Improvements for Power Supplies
- Pull request #981 at 067c009: Multiple type trainset lightglows
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #1008 at e827fbd: Fix: TrainCarOperations doesn't work as expected after resume.
- Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1012 at fbb87b0: doc:adds 3 news items to Manual
- Pull request #1014 at 3dbe81f: Bug fix for https://bugs.launchpad.net/or/+bug/2091895 Train disappears from train list window
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1003 at c734592: Clean up logging during loading #or-std-log
Csantucci
Csantucci approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Csantucci Csantucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK to me.

@mbm-OR
Copy link
Contributor Author

mbm-OR commented Dec 18, 2024

Thank you, Carlo.

@mbm-OR mbm-OR merged commit e5b8414 into openrails:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Csantucci Csantucci Csantucci approved these changes

Assignees

@mbm-OR mbm-OR

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbm-OR @Csantucci