Skip to content

Fix Stuck Locomotive Brakes After Initialization #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2025
Merged

Fix Stuck Locomotive Brakes After Initialization #1102

merged 3 commits into from
Jun 8, 2025

Conversation

SteelFill
Copy link
Contributor

Another quick fix for the next version, a nagging issue left in the wake of #916 and #997 is that locomotives not connected to the lead locomotive would get their locomotive brakes stuck on during initialization if the lead locomotive was initialized with the locomotive brakes applied if the locomotive brake was not synchronized by the distributed power system. This is because the locomotive brake would be initialized as if all locomotives were synchronized with the lead locomotive, but once initialized the trailing locomotive would ignore locomotive brake commands, resulting in stuck brakes (until re-initializing with the locomotive brake released).

Now, the locomotive brake won't be applied during initialization on any locomotives not connected to the lead locomotive unless independent brake sync is active. The locomotive may still develop brake cylinder pressure if the train brake is applied, but the train brake won't be stuck applied unlike the locomotive brake.

@SteelFill SteelFill added the bug Something isn't working label Jun 3, 2025
twpol pushed a commit that referenced this pull request Jun 3, 2025
@openrails-bot
Automatic merge of T1.5.1-1905-g2db0eb726 and 9 pull requests
8e799c0 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1098 at 6bbd2c6: Correct Use of Wheel Speed vs Ground Speed in Locomotive Physics
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 3, 2025
@openrails-bot
Automatic merge of T1.5.1-1905-g2db0eb726 and 9 pull requests
d2446be 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1098 at 34bd6a7: Correct Use of Wheel Speed vs Ground Speed in Locomotive Physics
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 3, 2025
@openrails-bot
Automatic merge of T1.5.1-1905-g2db0eb726 and 10 pull requests
a41b9c7 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1098 at 34bd6a7: Correct Use of Wheel Speed vs Ground Speed in Locomotive Physics
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 3, 2025
@openrails-bot
Automatic merge of T1.5.1-1910-gafcdfe10c and 9 pull requests
446522e 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 3, 2025
@openrails-bot
Automatic merge of T1.5.1-1910-gafcdfe10c and 10 pull requests
ea7574d 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1091 at 6bab3bf: Automatic speed control
twpol pushed a commit that referenced this pull request Jun 4, 2025
@openrails-bot
Automatic merge of T1.5.1-1910-gafcdfe10c and 10 pull requests
600700c 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at db81258: Automatic speed control
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 6, 2025
@openrails-bot
Automatic merge of T1.5.1-1910-gafcdfe10c and 10 pull requests
00cf5e6 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 53fe3c2: Automatic speed control
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 6, 2025
@openrails-bot
Automatic merge of T1.5.1-1910-gafcdfe10c and 10 pull requests
bf6132d 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at ac323a2: Automatic speed control
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 6, 2025
@openrails-bot
Automatic merge of T1.6-rc2-26-g74ecafa7f and 10 pull requests
c3e1d52 
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at ac323a2: Automatic speed control
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 7, 2025
@openrails-bot
Automatic merge of T1.6-rc2-26-g74ecafa7f and 10 pull requests
6753d14 
- Pull request #1072 at 16cf00c: Content Creation Shortcuts & Advanced Wagon Shape Interactions
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at ac323a2: Automatic speed control
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 8, 2025
@openrails-bot
Automatic merge of T1.6-rc2-26-g74ecafa7f and 10 pull requests
7a3c94a 
- Pull request #1072 at 076a8d3: Content Creation Shortcuts & Advanced Wagon Shape Interactions
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at ac323a2: Automatic speed control
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol pushed a commit that referenced this pull request Jun 8, 2025
@openrails-bot
Automatic merge of T1.6-rc2-26-g74ecafa7f and 10 pull requests
8d79762 
- Pull request #1072 at 076a8d3: Content Creation Shortcuts & Advanced Wagon Shape Interactions
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 520ac64: Automatic speed control
- Pull request #1097 at 63248a0: Fix For Delayed Particle Emitter Spawning
- Pull request #1099 at 5e8b056: Fix TCS orders not being sent to pantographs
- Pull request #1100 at cccb40a: Updates to German translations
- Pull request #1102 at c96c499: Fix Stuck Locomotive Brakes After Initialization
- Pull request #1103 at d2fae0f: Fix diverging force when exceeding max speed
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
twpol
twpol approved these changes Jun 8, 2025
View reviewed changes
Copy link
Member

@twpol twpol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 1.6, thanks!

@twpol twpol merged commit d0c2856 into openrails:release/1.6 Jun 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpol twpol twpol approved these changes

@cesarBLG cesarBLG cesarBLG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteelFill @twpol @cesarBLG