Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dialog system uses an incorrect WAI ARIA Role attribute #6602

Closed
thadguidry opened this issue May 13, 2024 · 0 comments · Fixed by #6603
Closed

The dialog system uses an incorrect WAI ARIA Role attribute #6602

thadguidry opened this issue May 13, 2024 · 0 comments · Fixed by #6603
Assignees
@thadguidry
Labels
maintainability Making it easier to maintain OpenRefine Theme: accessibility Highlights issues related to making the application more accessible to users with disabilities (WCAG

Comments

@thadguidry
Copy link
Member

The WAI-ARIA element attribute aria-role is deprecated and incorporated into browsers via only role 1 2

We should replace aria-role= with only role=

<div class="dialog-frame" style="min-width: 600px; visibility: visible;" aria-role="dialog" tabindex="-1">
to
<div class="dialog-frame" style="min-width: 600px; visibility: visible;" role="dialog" tabindex="-1">

To Reproduce

Steps to reproduce the behavior:

  1. Start OpenRefine
  2. Open console (or browser debugging tools)
  3. Notice error of aria-role

Current Results

Error in browser consoles while debugging various parts of OpenRefine's frontend.

Expected Behavior

no error about "aria-role" being unrecognized.

Screenshots

Versions

  • Operating System: Windows 11
  • Browser Version: Edge latest
  • JRE or JDK Version: JDK 21
  • OpenRefine: master

Datasets

Additional context
@thadguidry thadguidry added maintainability Making it easier to maintain OpenRefine Theme: accessibility Highlights issues related to making the application more accessible to users with disabilities (WCAG labels May 13, 2024
@thadguidry thadguidry self-assigned this May 13, 2024
@thadguidry thadguidry mentioned this issue May 13, 2024
Merged
@t8210103 t8210103 mentioned this issue May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thadguidry thadguidry

Labels
maintainability Making it easier to maintain OpenRefine Theme: accessibility Highlights issues related to making the application more accessible to users with disabilities (WCAG
Projects
None yet
Milestone
No milestone
1 participant
@thadguidry