bugfix: preserve 'empty_array_mt' behavior upon multiple loadings of the module #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
module Prior to this fix, when the module would be loaded several times (by-passing `package.loaded`), the `lua_cjson_new` function would override the `empty_array_mt` table in the registry with a new one. Comparison for equality between those tables would then fail, and the behavior would be broken. This was discovered after loading `cjson` *and* `cjson.safe` in the same application, resulting in two calls to `lua_cjson_new`.
|
@doujiang24 Would you be interested in reviewing this change as well? Thanks :) |
doujiang24
reviewed
Dec 17, 2016
| * If multiple calls to lua_cjson_new() are made, | ||
| * this prevents overriding the table at the given | ||
| * registry's index with a new one. | ||
| */ |
There was a problem hiding this comment.
Maybe add lua_pop(L, 1) is better here?
There was a problem hiding this comment.
To pop the nil value from the stack? Yes, indeed.
empty_array_mt table in the registry
|
Merged with minor edits in the commit log message. Thanks! |
|
Thanks! @doujiang24 Thanks for taking a look! |
thibaultcha
added a commit
to Kong/kong
that referenced
this pull request
Dec 20, 2016
Use a workaround until openresty/lua-cjson#16 is included in an OpenResty formal release.
hbagdi
added a commit
to hbagdi/kong
that referenced
this pull request
Nov 4, 2017
Since openresty/lua-cjson#16 has been merged and Openresty we use includes this fix, we can get rid off the workarounds in our code.
thibaultcha
pushed a commit
to Kong/kong
that referenced
this pull request
Nov 8, 2017
Since openresty/lua-cjson#16 has been merged in OpenResty, we can get rid of the workarounds in place for this bug. From #3013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, when the module would be loaded several times
(by-passing the
package.loadedlookup), thelua_cjson_new()function wouldoverride the
empty_array_mttable in the Lua Registry with a new one.Comparison for equality between those tables would then fail, and the
encoding behavior would be broken.
This was discovered after loading
cjsonandcjson.safein the sameapplication, resulting in two calls to
lua_cjson_new():DChangelog: