a problem with lua ffi in openresty

[mike96265]

software

nginx version: openresty/1.15.8.1

operating system: debian 9

system luajit: LuaJIT 2.1.0-beta3 -- Copyright (C) 2005-2017 Mike Pall. http://luajit.org/

openresty luajit: LuaJIT 2.1.0-beta3 -- Copyright (C) 2005-2017 Mike Pall. http://luajit.org/

test case

-- filename: gateway/test.lua
local ffi = require "ffi"

ffi.cdef [=[
    typedef struct _TrigxNode {
        int val;
        struct _TrigxNode *char_nodes[64];
        struct _TrigxNode *rgx_next;
        int rgx_raw_len;
        void *re;
        char *rgx;
    } TrigxNode;
    TrigxNode *create_trigx_node();
    void trigx_insert(TrigxNode *root, const char *word, int len_word, int val);
    int trigx_search(TrigxNode *root, const char *word, int len_word);
    void trigx_free(TrigxNode *root);
   ]=];

local C = ffi.load("trigx_tree")

local node = C.create_trigx_node()
C.trigx_insert(node, '/menu/', 6, 10)
local result = C.trigx_search(node, '/menu/', 6)
if ngx ~= nil then
    --  test in openresty
    ngx.say("result: " .. result)
else
    -- test in luajit
    print("result: " .. result)
end
return

# filename: conf.d/nginx.conf
http {

    init_worker_by_lua_block {
        local uuid = require 'resty.jit-uuid'
        uuid.seed()
        local verbose = false
        if verbose then
            local dump = require "jit.dump"
            dump.on(nil, "./jit.log")
        else
            local v = require "jit.v"
            v.on("./jit.log")
        end
        require "resty.core"
    }

    server {
        listen 9090;

        location / {
            content_by_lua_file "gateway/test.lua";
        }

        location /login {
            default_type 'application/json';
            content_by_lua_file 'gateway/login.lua';
        }

        location /wechat-callback {
            content_by_lua_file 'gateway/wechat_identify.lua';
        }

    }
}

when i call the ffi function by shell, luajit -i gateway/test.lua,I can see the right result are printed

but when i try to call test.lua in nginx worker, curl 'localhost:9090/abc',error occured

I have no idea about how this problem occured

[mike96265]

I use calloc rather malloc to allocate memory then problem solved

[doujiang24]

you should not ffi cdef the same thing more than one time, you can move them into a Lua module, like: https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.lua then you can call in like: content_by_lua_block { require "xx".go() } yukityan <notifications@github.com> 于2019年7月16日周二 下午3:17写道：

…

software nginx version: *openresty/1.15.8.1 <http://1.15.8.1>* operating system: *debian 9* test case -- filename: gateway/test.lualocal ffi = require "ffi" ffi.cdef [=[ typedef struct _TrigxNode { int val; struct _TrigxNode *char_nodes[64]; struct _TrigxNode *rgx_next; int rgx_raw_len; void *re; char *rgx; } TrigxNode; TrigxNode *create_trigx_node(); void trigx_insert(TrigxNode *root, const char *word, int len_word, int val); int trigx_search(TrigxNode *root, const char *word, int len_word); void trigx_free(TrigxNode *root); ]=]; local C = ffi.load("trigx_tree") local node = C.create_trigx_node() C.trigx_insert(node, '/menu/', 6, 10)local result = C.trigx_search(node, '/menu/', 6)if ngx ~= nil then ngx.say("result: " .. result)else print("result: " .. result)endreturn # filename: conf.d/nginx.confhttp { init_worker_by_lua_block { local uuid = require 'resty.jit-uuid' uuid.seed() local verbose = false if verbose then local dump = require "jit.dump" dump.on(nil, "./jit.log") else local v = require "jit.v" v.on("./jit.log") end require "resty.core" } server { listen 9090; location / { content_by_lua_file "gateway/test.lua"; } location /login { default_type 'application/json'; content_by_lua_file 'gateway/login.lua'; } location /wechat-callback { content_by_lua_file 'gateway/wechat_identify.lua'; } } } when i call the ffi function by shell, *luajit -i gateway/test.lua*,I can see the right result are printed [image: image] <https://user-images.githubusercontent.com/30937220/61273379-eef1a100-a7db-11e9-91ae-2ded27727b88.png> but when i try to call test.lua in nginx worker, *curl 'localhost:9090/abc'*,error occured [image: image] <https://user-images.githubusercontent.com/30937220/61273602-7f2fe600-a7dc-11e9-88bf-d763d5d7a383.png> I have no idea about how this problem occured — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1562?email_source=notifications&email_token=AAELIF2M5BOEJEVUJWBC3TLP7VYXBA5CNFSM4ID52HMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7MSF6Q>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAELIF3HK546MRFGPNM42FDP7VYXBANCNFSM4ID52HMA> .

[mike96265]

I know that ffi cdef shoud only execute once,But in my test case, if my my ffi extension work correctly, when the first request arrived, It should give me the right answer, and when the second request arrived, It should throw cdef dumplicated error. doujiang <notifications@github.com> 于2019年7月20日周六 上午11:19写道：

…

you should not ffi cdef the same thing more than one time, you can move them into a Lua module, like: https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.lua then you can call in like: content_by_lua_block { require "xx".go() } yukityan ***@***.***> 于2019年7月16日周二 下午3:17写道： > software nginx version: *openresty/1.15.8.1 <http://1.15.8.1>* operating > system: *debian 9* test case > > -- filename: gateway/test.lualocal ffi = require "ffi" > > ffi.cdef [=[ > typedef struct _TrigxNode { > int val; > struct _TrigxNode *char_nodes[64]; > struct _TrigxNode *rgx_next; > int rgx_raw_len; > void *re; > char *rgx; > } TrigxNode; > TrigxNode *create_trigx_node(); > void trigx_insert(TrigxNode *root, const char *word, int len_word, int val); > int trigx_search(TrigxNode *root, const char *word, int len_word); > void trigx_free(TrigxNode *root); > ]=]; > local C = ffi.load("trigx_tree") > local node = C.create_trigx_node() > C.trigx_insert(node, '/menu/', 6, 10)local result = C.trigx_search(node, '/menu/', 6)if ngx ~= nil then > ngx.say("result: " .. result)else > print("result: " .. result)endreturn > > # filename: conf.d/nginx.confhttp { > > init_worker_by_lua_block { > local uuid = require 'resty.jit-uuid' > uuid.seed() > local verbose = false > if verbose then > local dump = require "jit.dump" > dump.on(nil, "./jit.log") > else > local v = require "jit.v" > v.on("./jit.log") > end > require "resty.core" > } > > server { > listen 9090; > > location / { > content_by_lua_file "gateway/test.lua"; > } > > location /login { > default_type 'application/json'; > content_by_lua_file 'gateway/login.lua'; > } > > location /wechat-callback { > content_by_lua_file 'gateway/wechat_identify.lua'; > } > > } > } > > when i call the ffi function by shell, *luajit -i gateway/test.lua*,I can > see the right result are printed > > [image: image] > < https://user-images.githubusercontent.com/30937220/61273379-eef1a100-a7db-11e9-91ae-2ded27727b88.png > > > but when i try to call test.lua in nginx worker, *curl > 'localhost:9090/abc'*,error occured > [image: image] > < https://user-images.githubusercontent.com/30937220/61273602-7f2fe600-a7dc-11e9-88bf-d763d5d7a383.png > > > I have no idea about how this problem occured > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > < #1562?email_source=notifications&email_token=AAELIF2M5BOEJEVUJWBC3TLP7VYXBA5CNFSM4ID52HMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7MSF6Q >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAELIF3HK546MRFGPNM42FDP7VYXBANCNFSM4ID52HMA > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1562?email_source=notifications&email_token=AHMBBBBSJ66NIDFAISCPIB3QAJ755A5CNFSM4ID52HMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NFMTQ#issuecomment-513431118>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHMBBBAYSQNFYZ5OCUJIHZLQAJ755ANCNFSM4ID52HMA> .