Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The system appears to be sending multiple commands on keyboard press #623

Closed
BrianAdams opened this issue Jan 19, 2017 · 6 comments
Closed
Assignees
Labels
Milestone

Comments

@BrianAdams
Copy link
Contributor

For instance, the hitting light will toggle it off-on-off-on.

@BrianAdams BrianAdams added this to the 31.0.0 milestone Jan 19, 2017
@BrianAdams BrianAdams self-assigned this Jan 19, 2017
@BrianAdams
Copy link
Contributor Author

Checked the input manager to ensure it was not somehow holding on to listeners. Registered several different presets, including the same one a couple time. In mock mode, sending a light command only happened once.

@gilborty
Copy link

Was this reported on a vehicle?

@BrianAdams
Copy link
Contributor Author

@nerdgilbert , yes. The test vehicle Grau was using. If you can get a chance to take a look on vehicle, I think that is the next step. Might be worth capturing the serial traffic while recreating the issue.

@BrianAdams
Copy link
Contributor Author

@spiderkeys had a sense it might have to do with the syncTargetPower function that keeps retrying every 33ms until it gets a lights_tpow response from the MCU. That it may be the round trip is taking too long and the message gets sent again. Now how a power off message would trigger a power on again is still a mystery.

@spiderkeys
Copy link

spiderkeys commented Jan 20, 2017

The command going to the firmware is a specific value; there is no toggle API. The only place the concept of toggling exists is the browser client, so delayed/repeated toggles are probably building up between the client and server. This behaviour has exhibited itself in many other commands as well, happening especially often on the BBB.

@BrianAdams
Copy link
Contributor Author

This was tied to the gamepad press generating multiple gamepad click events. Opened other issues. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants