Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for openRTB 2.4 #68

Closed
wants to merge 1 commit into from
Closed

Support for openRTB 2.4 #68

wants to merge 1 commit into from

Conversation

vishals79
Copy link

@vishals79 vishals79 commented Jun 28, 2016

Added openrtb-validator support for openRTB 2.4.

Spec: openRTB API Specification V 2.4

@drjbutler
Copy link
Member

Thank you for your contribution. We had a couple v2.4 schema files cross and accepted another. I reviewed with the contributor line by line against the change log in the v2.4 spec, but could you perhaps compare your version against this to see if we missed anything?

Thanks!

@drjbutler drjbutler closed this Jul 20, 2016
@vishals79
Copy link
Author

@drjbutler : Everything looks fine just one thing. In 2.4 spec an attribute "isrc" has been added. Based on the description provided "isrc" follows International Standard Recording Code conforming to ISO-3901.

So, we can use this
"isrc": {
"type": "string",
"pattern": "[iI][sS][rR][cC] [a-zA-Z]{2}-[a-zA-Z0-9]{3}-[0-9]{2}-[0-9]{5}"
}

instead of

"isrc": {
"type": "string"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants