Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: proxy requests if requested #428

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat: proxy requests if requested #428

merged 1 commit into from
Apr 15, 2024

Conversation

SimonThordal
Copy link
Contributor

Closes #419

@SimonThordal SimonThordal requested a review from pudo April 15, 2024 10:55
@SimonThordal SimonThordal mentioned this pull request Apr 15, 2024
Closed
pudo
pudo approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@pudo pudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My biggest concern is that we use not only httpx but also aiohttp somewhere, but I cannot find evidence of that right now with a simple search of the codebase.

yente/data/util.py Show resolved Hide resolved
@SimonThordal SimonThordal merged commit 22dbb63 into main Apr 15, 2024
4 checks passed
@SimonThordal
Copy link
Contributor Author

Looks good. My biggest concern is that we use not only httpx but also aiohttp somewhere, but I cannot find evidence of that right now with a simple search of the codebase.

Can't find it either, so let's merge it in :)

@SimonThordal SimonThordal deleted the use-proxy-if-available branch April 15, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pudo pudo pudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow httpx to use proxies
2 participants
@SimonThordal @pudo