Skip to content

Conversation

dlabordus
Copy link
Contributor

@dlabordus dlabordus commented Oct 10, 2022

closes #930
closes #931
closes #932
closes #935
closes #936
closes #937

Refactoring of Later Binding Plugins to reuse the FCDA List, not only for Later Binding.

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus added the Kind: Enhancement New Request label Oct 10, 2022
@dlabordus dlabordus self-assigned this Oct 10, 2022
Dennis Labordus added 2 commits October 10, 2022 13:26
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
…other subscriber plugins

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus changed the title feat(editor/subscriber): Added plugin for Subscriber Logical Nodes (GOOSE) feat(editor/subscriber): Added plugin for Subscriber Logical Nodes (GOOSE/SMV) Oct 10, 2022
Dennis Labordus added 2 commits October 10, 2022 15:32
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
@dlabordus dlabordus marked this pull request as ready for review October 11, 2022 13:54
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is something still incorrect. Also provided translations and some code style bla bla

Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabordus dlabordus merged commit 971f0c1 into main Oct 13, 2022
@dlabordus dlabordus deleted the subscriber-ln-goose branch October 13, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment