remove deploy on pull request to the main branch #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I've also added a restriction rule for the main (default) branch. |
F-Shahali
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Previously, We had deployment on the main domain based on a pull request to the main branch feature in the
build.yml.The issue with this feature is that, since this repository is public, you can easily send a pull request from any branch of any of your own repositories to this branch, or you can fork it and add anything (maybe harmful) and send a pull request from yours to the main branch, with ability to deploy, it may lead to deployment of the random (may malicious and harmful) website on our domain.
We will soon add deployment on the dev domain and also restrict action execution from pull requests from foreign repositories.
Any other comments?