require openseadragon if it doesn't exist #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `[openseadragon-svg-overlay] requires OpenSeadragon` error when doing this: ``` import OpenSeadragon from 'openseadragon'; import 'svg-overlay'; ``` Borrowed style from https://github.com/usnistgov/OpenSeadragonFiltering/blob/master/openseadragon-filtering.js setting OpenSeadragon object to `$`
iangilman
approved these changes
Mar 13, 2018
openseadragon-svg-overlay.js
Outdated
| $ = window.OpenSeadragon; | ||
|
|
||
| if (!$) { | ||
| $ = require('openseadragon'); |
There was a problem hiding this comment.
This line should be tabbed out.
|
@avandecreme FYI :) |
|
Beautiful, thank you! |
iangilman
reviewed
Mar 20, 2018
| if (!window.OpenSeadragon) { | ||
| console.error('[openseadragon-svg-overlay] requires OpenSeadragon'); | ||
| return; | ||
| $ = window.OpenSeadragon; |
There was a problem hiding this comment.
I've just discovered that this line causes a conflict with jQuery because it's missing var... I've fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
[openseadragon-svg-overlay] requires OpenSeadragonerror when doing this:Borrowed style from https://github.com/usnistgov/OpenSeadragonFiltering/blob/master/openseadragon-filtering.js
setting OpenSeadragon object to
$