[Backport 2.x] MultiDataSource feature merge (#2334) #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
seraphjiang
requested review from
kavilla,
ashwin-pc,
AMoo-Miki,
zengyan-amazon,
kristenTian and
zhongnansu
|
Hey @mpabba3003 is this a duplicate backport PR of #2399? If not, what is changed? pls add the changes in the description. It seems to me just a backport which is confusing. |
@ananzh we should close #2399 . |
kavilla
reviewed
Sep 27, 2022
| const WRAPPING_KEY_SIZE: number = 32; | ||
|
|
||
| export const configSchema = schema.object({ | ||
| enabled: schema.boolean({ defaultValue: false }), |
There was a problem hiding this comment.
I would add this examples in the config/opensearch_dashboards.yml. It makes it a little bit easier for community members to use.
For example: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/config/opensearch_dashboards.yml#L225
we could add
# data_source.enabled: false
and a some quick notes about feature
kavilla
approved these changes
Sep 27, 2022
| clientPool: schema.object({ | ||
| size: schema.number({ defaultValue: 5 }), | ||
| }), | ||
| audit: schema.object({ |
There was a problem hiding this comment.
nit: how come we want enable multiple log files? would there be a reason to just utilize existing auditing functionality?
There was a problem hiding this comment.
audit log is different with service log, for data source we'll have both. You can check #1986 for more discussion. cc @kristenTian
| @@ -116,13 +126,16 @@ export class StepIndexPattern extends Component<StepIndexPatternProps, StepIndex | |||
|
|
|||
| ILLEGAL_CHARACTERS = [...indexPatterns.ILLEGAL_CHARACTERS]; | |||
|
|
|||
| dataSrouceEnabled: boolean; | |||
7 tasks
zengyan-amazon
approved these changes
Sep 29, 2022
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Nov 1, 2022
geckodriver - only used in running functional tests. It got bumped to 11.8.5 on 2022-06-02. geckodriver has been bumped to 3.0.2 before and backported to 2.x PR: opensearch-project#2397 However, due to this PR: opensearch-project#2409 geckodriver is set back to 3.0.1. Therefore, we will reset it to 3.0.2. Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Nov 1, 2022
geckodriver - only used in running functional tests. It got bumped to 11.8.5 on 2022-06-02. geckodriver has been bumped to 3.0.2 before and backported to 2.x PR: opensearch-project#2397 However, due to this PR: opensearch-project#2409 geckodriver is set back to 3.0.1. Therefore, we will reset it to 3.0.2. Issue Resolved: opensearch-project#1764 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
8 tasks
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Nov 1, 2022
geckodriver - only used in running functional tests. It got bumped to 11.8.5 on 2022-06-02. geckodriver has been bumped to 3.0.2 before and backported to 2.x PR: opensearch-project#2397 However, due to this PR: opensearch-project#2409 geckodriver is set back to 3.0.1. Therefore, we will reset it to 3.0.2. Issue Resolved: opensearch-project#1764 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
that referenced
this pull request
Nov 1, 2022
geckodriver - only used in running functional tests. It got bumped to 11.8.5 on 2022-06-02. geckodriver has been bumped to 3.0.2 before and backported to 2.x PR: #2397 However, due to this PR: #2409 geckodriver is set back to 3.0.1. Therefore, we will reset it to 3.0.2. Issue Resolved: #1764 Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com>
pjfitzgibbons
pushed a commit
to pjfitzgibbons/OpenSearch-Dashboards
that referenced
this pull request
Dec 1, 2022
opensearch-project#2409) Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Co-authored-by: Kristen Tian <105667444+kristenTian@users.noreply.github.com>
pjfitzgibbons
pushed a commit
to pjfitzgibbons/OpenSearch-Dashboards
that referenced
this pull request
Dec 1, 2022
opensearch-project#2409) Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Co-authored-by: Kristen Tian <105667444+kristenTian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mpabba3003 amazonmanideep@gmail.com
Description
[Backport 2.x] MultiDataSource feature merge (#2334)
Backport 890a4b6 from #2334