-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CVE-2022-33987][2.x]Re-upgrade geckodriver to 3.0.2 #2709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
changed the title
[CVE][2.x]Upgrade geckodriver to 3.0.2 to partially fix CVE-2022-33987
[CVE-2022-33987][2.x]Re-upgrade geckodriver to 3.0.2
Nov 1, 2022
geckodriver - only used in running functional tests. It got bumped to 11.8.5 on 2022-06-02. geckodriver has been bumped to 3.0.2 before and backported to 2.x PR: opensearch-project#2397 However, due to this PR: opensearch-project#2409 geckodriver is set back to 3.0.1. Therefore, we will reset it to 3.0.2. Issue Resolved: opensearch-project#1764 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
force-pushed
the
bump-geckodriver
branch
from
November 1, 2022 04:49
9332719
to
021b4ab
Compare
ananzh
added
cve
Security vulnerabilities detected by Dependabot or Mend
backport
v2.4.0
'Issues and PRs related to version v2.4.0'
labels
Nov 1, 2022
abbyhu2000
approved these changes
Nov 1, 2022
joshuarrrr
approved these changes
Nov 1, 2022
manasvinibs
approved these changes
Nov 1, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-2709-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 107a400d2df846a3b73e336c4072afb6de53813b
# Push it to GitHub
git push --set-upstream origin backport/backport-2709-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4 Then, create a pull request where the |
To make package consistency, this PR is superseded by this later one: #2772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
geckodriver - only used in running functional tests. It got bumped to 11.8.5 on 2022-06-02.
geckodriver has been bumped to 3.0.2 before and backported to 2.x PR: #2397
However, due to this PR:
#2409 geckodriver is set back to 3.0.1. Therefore, we will reset it to 3.0.2.
Issues Resolved
#1764
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr