Skip to content

Conversation

tandonks
Copy link
Contributor

@tandonks tandonks commented Aug 9, 2025

Description

Adding ScriptedAvg class to painless spi to allowlist usage from plugins
Followup PR to: #18411

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link
Contributor

github-actions bot commented Aug 9, 2025

❌ Gradle check result for f7ad412: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link
Contributor

github-actions bot commented Aug 9, 2025

❌ Gradle check result for b163b00: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link
Contributor

❌ Gradle check result for 4574641: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link
Contributor

✅ Gradle check result for 2108b6a: SUCCESS

Copy link

codecov bot commented Aug 10, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.89%. Comparing base (10ff9d3) to head (e37dbd6).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...a/org/opensearch/common/io/stream/Streamables.java 40.00% 3 Missing ⚠️
...earch/search/aggregations/metrics/InternalAvg.java 87.50% 0 Missing and 1 partial ⚠️
...earch/aggregations/metrics/InternalValueCount.java 85.71% 0 Missing and 1 partial ⚠️
...aggregations/metrics/ScriptedMetricAggregator.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19006      +/-   ##
============================================
- Coverage     72.94%   72.89%   -0.06%     
+ Complexity    69523    69440      -83     
============================================
  Files          5647     5647              
  Lines        319166   319175       +9     
  Branches      46165    46168       +3     
============================================
- Hits         232828   232653     -175     
- Misses        67539    67709     +170     
- Partials      18799    18813      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link
Contributor

❌ Gradle check result for b6161ea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link
Contributor

✅ Gradle check result for ba68f34: SUCCESS

Copy link
Contributor

@bharath-techie bharath-techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Copy link
Contributor

✅ Gradle check result for e37dbd6: SUCCESS

@bharath-techie bharath-techie merged commit 2e6c478 into opensearch-project:main Aug 19, 2025
30 of 31 checks passed
atris pushed a commit to atris/OpenSearch that referenced this pull request Aug 28, 2025
…opensearch-project#19006)

* Adding ScriptedAvg class to painless spi to allowlist usage from plugins

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Adding change to CHANGELOG.md

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing violations

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing UTs

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Adding comments and removing unused code

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing violations

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Sep 5, 2025
…opensearch-project#19006)

* Adding ScriptedAvg class to painless spi to allowlist usage from plugins

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Adding change to CHANGELOG.md

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing violations

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing UTs

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Adding comments and removing unused code

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing violations

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
…opensearch-project#19006)

* Adding ScriptedAvg class to painless spi to allowlist usage from plugins

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Adding change to CHANGELOG.md

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing violations

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing UTs

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Adding comments and removing unused code

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

* Fixing violations

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>

---------

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants