[1.x backport] Fix opensearch-env always sources the environment from hardcoded file in #875 #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opensearch-project#875) distribution/bin/opensearch-env always sources the environment from the default environment file /etc/default/opensearch. This is an issue if we want to run multiple instances of OpenSearch on the same host. This change lets users override the default behavior by not sourcing the default environment file in case OPENSEARCH_PATH_CONF is set. Signed-off-by: xuezhou25 <85715413+xuezhou25@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
force-pushed
the
opensearch-1.x-backport-e3d86baa5a97a813072cb3d5fe9b466d31a44f31
branch
from
d94d766 to
9e36614
Compare
|
✅ Gradle Check success d94d766983248963ea606de48e939547974019af |
tlfeng
approved these changes
Apr 14, 2022
tlfeng
added
backport
peterzhuamazon
deleted the
opensearch-1.x-backport-e3d86baa5a97a813072cb3d5fe9b466d31a44f31
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distribution/bin/opensearch-env always sources the environment from the default environment file /etc/default/opensearch. This is an issue if we want to run multiple instances of OpenSearch on the same host. This change lets users override the default behavior by not sourcing the default environment file in case OPENSEARCH_PATH_CONF is set.
Signed-off-by: xuezhou25 85715413+xuezhou25@users.noreply.github.com
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
[1.x backport] Fix opensearch-env always sources the environment from hardcoded file in #875
Issues Resolved
opensearch-project/opensearch-build#1545 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.