-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve centos7 osd runner to correctly export fpm and allows dynamic node version switch #1888
Improve centos7 osd runner to correctly export fpm and allows dynamic node version switch #1888
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1888 +/- ##
=========================================
Coverage 94.54% 94.54%
Complexity 19 19
=========================================
Files 178 178
Lines 3630 3630
Branches 27 27
=========================================
Hits 3432 3432
Misses 194 194
Partials 4 4 Continue to review full report at Codecov.
|
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
I will test this change in my #1807 once the new tag is ready |
docker/ci/dockerfiles/build.centos7.opensearch-dashboards.x64.arm64.dockerfile
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…ds-ci-runner-improvement-rpm
…hub.com:peterzhuamazon/opensearch-build into opensearch-dashboards-ci-runner-improvement-rpm
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
I am performing testing in #1807 by using the new image generated by this PR. I will approve once my test is successful. |
Verified that the new image is working. (sample run) |
Description
Improve centos7 osd runner to correctly export fpm and allows dynamic node version switch
-e "NODE_VERSION=14.18.2"
it uses 14.18.2. We can add more versions easily later. This makes the dashboards builds the same way as opensearch since you can now apply different node versions for different releases in input manifest.Test image: https://hub.docker.com/r/opensearchstaging/ci-runner/tags?page=1&ordering=last_updated&name=ci-runner-centos7-opensearch-dashboards-build-v1
Thanks.
Issues Resolved
#1887
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.