Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve centos7 osd runner to correctly export fpm and allows dynamic node version switch #1888

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Apr 1, 2022

Description

Improve centos7 osd runner to correctly export fpm and allows dynamic node version switch

  1. The fpm utility now correctly exported to env, means OSD core build rpm will not crash anymore
  2. Add an entrypoint to dynamically export node version when runner starts. If no params, use 10.24.1; if use -e "NODE_VERSION=14.18.2" it uses 14.18.2. We can add more versions easily later. This makes the dashboards builds the same way as opensearch since you can now apply different node versions for different releases in input manifest.
% docker run --rm -it -u root opensearchstaging/ci-runner:test123
v10.24.1 is already installed.
Now using node v10.24.1 (npm v6.14.12)
Now using node v10.24.1 (npm v6.14.12)
% docker run --rm -it -e "NODE_VERSION=14.18.2" opensearchstaging/ci-runner:test123
v14.18.2 is already installed.
Now using node v14.18.2 (npm v6.14.15)
Now using node v14.18.2 (npm v6.14.15)

Test image: https://hub.docker.com/r/opensearchstaging/ci-runner/tags?page=1&ordering=last_updated&name=ci-runner-centos7-opensearch-dashboards-build-v1

Thanks.

Issues Resolved

#1887

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #1888 (70482e9) into main (a638264) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1888   +/-   ##
=========================================
  Coverage     94.54%   94.54%           
  Complexity       19       19           
=========================================
  Files           178      178           
  Lines          3630     3630           
  Branches         27       27           
=========================================
  Hits           3432     3432           
  Misses          194      194           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a638264...70482e9. Read the comment docs.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@tianleh
Copy link
Member

tianleh commented Apr 1, 2022

I will test this change in my #1807 once the new tag is ready

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…hub.com:peterzhuamazon/opensearch-build into opensearch-dashboards-ci-runner-improvement-rpm
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@tianleh
Copy link
Member

tianleh commented Apr 4, 2022

I am performing testing in #1807 by using the new image generated by this PR. I will approve once my test is successful.

@tianleh
Copy link
Member

tianleh commented Apr 4, 2022

Verified that the new image is working. (sample run)
Screen Shot 2022-04-04 at 11 51 33 AM

@peterzhuamazon peterzhuamazon merged commit 27a69d0 into opensearch-project:main Apr 4, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-dashboards-ci-runner-improvement-rpm branch April 4, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPM build for core dashboards failed in fpm assemble step
3 participants