SRVLOGIC-75: Update openshift knative docs with Serverless Logic Workflow guides for 1.32.0 #89

akumar074 · 2023-01-31T04:43:01Z

KOGITO-7676: Adding PostgreSQL DB migration guide (#183)

[KOGITO-8353] Introduce Camel Routes integration guide (#269)

[KOGITO-7282] - [KSW-Guides] Deploying on Kubernetes Clusters (#256)

[KOGITO-8304] - Document the usage of all-in-one jobs-service image (#261)

[KOGITO-8141][KOGITO-8309] - Enhancing Knative Eventing guide with info about local testing (#260)

[KOGITO-8167] Adding event state timeout (#248)

openshift-ci-robot · 2023-01-31T04:43:04Z

@akumar074: This pull request references SRVLOGIC-75 which is a valid jira issue.

In response to this:

KOGITO-7676: Adding PostgreSQL DB migration guide (#183)

[KOGITO-8353] Introduce Camel Routes integration guide (#269)

[KOGITO-7282] - [KSW-Guides] Deploying on Kubernetes Clusters (#256)

[KOGITO-8304] - Document the usage of all-in-one jobs-service image (#261)

[KOGITO-8141][KOGITO-8309] - Enhancing Knative Eventing guide with info about local testing (#260)

[KOGITO-8167] Adding event state timeout (#248)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2023-01-31T04:43:05Z

✅ Deploy Preview for jazzy-shortbread-5f62b7 ready!

Name	Link
🔨 Latest commit	`872386d`
🔍 Latest deploy log	https://app.netlify.com/sites/jazzy-shortbread-5f62b7/deploys/63e65a7515aef200084d190a
😎 Deploy Preview	https://deploy-preview-89--jazzy-shortbread-5f62b7.netlify.app/docs/latest/serverless-logic/cloud/build-and-deploy-with-serverless-operator-on-kubernetes
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ricardozanini

I'll check if Camel needs to be removed from this branch.

ricardozanini · 2023-01-31T10:51:09Z

antora.yml

    quarkus_cli_url: 'https://quarkus.io/guides/cli-tooling'
    spec_website_url: 'https://serverlessworkflow.io/'
    spec_doc_url: >-
      https://github.com/serverlessworkflow/specification/blob/0.8.x/specification.md


We need to update the downstream versions here.

quarkus_version: 2.13.5.Final-redhat-00003
kogito_version_redhat: 1.32.0.Final-redhat-00003
kn_cli_version: 0.26.0

modules/serverless-logic/pages/integrations/camel-routes-integration.adoc

MarianMacik

I added versions of what I know.

MarianMacik · 2023-02-01T09:37:24Z

antora.yml

    quarkus_cli_url: 'https://quarkus.io/guides/cli-tooling'
    spec_website_url: 'https://serverlessworkflow.io/'
    spec_doc_url: >-
      https://github.com/serverlessworkflow/specification/blob/0.8.x/specification.md


quarkus_version: 2.13.5.Final-redhat-00003
kogito_version_redhat: 1.32.0.Final-redhat-00003
kn_cli_version: 0.26.0

modules/serverless-logic/pages/integrations/camel-routes-integration.adoc

radtriste

should be corrected upstream as well I guess

modules/serverless-logic/pages/cloud/deploying-on-kubernetes.adoc

modules/serverless-logic/pages/cloud/common/_proc_deploy_sw_kubectl.adoc

modules/serverless-logic/pages/core/custom-functions-support.adoc

modules/serverless-logic/pages/core/timeouts-support.adoc

antora.yml

modules/serverless-logic/pages/persistence/postgresql-flyway-migration.adoc

radtriste · 2023-02-01T20:34:01Z

modules/serverless-logic/pages/persistence/postgresql-flyway-migration.adoc

+= Migrating Your PostgreSQL Database with a Kogito upgrade
+:flyway_install_url: https://flywaydb.org/download/community
+:flyway_migrate_existing_url: https://flywaydb.org/documentation/learnmore/existing
+:kogito_ddl_script_url: https://repo1.maven.org/maven2/org/kie/kogito/kogito-ddl


link should be updated or ?

The ddl one? I think we should if it's a production counter-part and move it to antora.yaml and group all the "must be updated downstream links" together.

Is this the correct mvn repository, it should come from? https://maven.repository.redhat.com/ga/org/kie/kogito/
I can not find the kogito-ddl here.

@ricardozanini are we shipping any persistence for now ?

@cristianonicolai cc

Do we have this DDL for DP4? Otherwise we will need to change the doc.

@ricardozanini yeah, persistence has been there for a while now, but I guess we missed including the links to download the ddl zip file. I would say we need to get this included and have the correct link for the productised artefacts.

@radtriste @cristianonicolai so how do we productize these DDL zip file?

AFAIK these are just maven artefacts that get published in the prod Maven repo

FYI I've started a discussion on gchat to discuss how it is done on productization side.

As per the discussion, I'll keep the link as it is for now, and it will be fixed in a later release.

modules/serverless-logic/pages/persistence/postgresql-flyway-migration.adoc

akumar074 · 2023-02-02T09:53:15Z

@ricardozanini @radtriste @MarianMacik Updated the PR with comments. Please take a look.

…fo about local testing (#260)

…#261)

…ow applications on Kubernetes

akumar074 · 2023-02-06T12:43:56Z

@ricardozanini @radtriste @MarianMacik I have updated the PR with Kogito-docs 1.32.x. earlier there were some commits missing. Please take a look.

...es/serverless-logic/pages/cloud/build-and-deploy-with-serverless-operator-on-kubernetes.adoc

antora.yml

modules/ROOT/nav.adoc

...es/serverless-logic/pages/cloud/build-and-deploy-with-serverless-operator-on-kubernetes.adoc

akumar074 · 2023-02-09T09:15:16Z

Added changes from PR comments. Please take a look.

akumar074 · 2023-02-10T07:39:28Z

@ricardozanini I have updated the PR. Please take a look.

ricardozanini

@radtriste wanna take a final look?

...es/serverless-logic/pages/cloud/build-and-deploy-with-serverless-operator-on-kubernetes.adoc

openshift-ci · 2023-02-10T15:11:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akumar074, MarianMacik, radtriste, ricardozanini

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

akumar074 requested a review from ricardozanini January 31, 2023 04:43

openshift-ci-robot added the jira/valid-reference label Jan 31, 2023

ricardozanini reviewed Jan 31, 2023

View reviewed changes

MarianMacik reviewed Feb 1, 2023

View reviewed changes

radtriste requested changes Feb 1, 2023

View reviewed changes

akumar074 force-pushed the migrate-1.33.x branch from dd31971 to 2e550cb Compare February 2, 2023 09:50

akumar074 added 7 commits February 6, 2023 16:00

[KOGITO-8167] Adding event state timeout (#248)

2abfb1d

[KOGITO-8141][KOGITO-8309] - Enhancing Knative Eventing guide with in…

33f17f7

…fo about local testing (#260)

[KOGITO-8304] - Document the usage of all-in-one jobs-service image (…

6cb5c4b

…#261)

[KOGITO-7676] Adding Postgres DB migration guide (#277)

361dc3e

[KOGITO-7282] - [KSW-Guides] Deploying on Kubernetes Clusters (#267)

4476286

[KOGITO-8314] [KSW-Guides] Using Serverless Operator to deploy workfl…

5706638

…ow applications on Kubernetes

[KOGITO-8250]-Working with Open API callbacks (#285)

c0a7c0a

akumar074 force-pushed the migrate-1.33.x branch from 2e550cb to dfb77fe Compare February 6, 2023 12:33

Minor fixes

06d229d

akumar074 force-pushed the migrate-1.33.x branch from dfb77fe to 06d229d Compare February 6, 2023 13:07

ricardozanini changed the title ~~SRVLOGIC-75: Update openshift knative docs with Serverless Logic Workflow guides for 1.33.0~~ SRVLOGIC-75: Update openshift knative docs with Serverless Logic Workflow guides for 1.32.0 Feb 6, 2023

ricardozanini reviewed Feb 6, 2023

View reviewed changes

...es/serverless-logic/pages/cloud/build-and-deploy-with-serverless-operator-on-kubernetes.adoc Outdated Show resolved Hide resolved

...es/serverless-logic/pages/cloud/build-and-deploy-with-serverless-operator-on-kubernetes.adoc Outdated Show resolved Hide resolved

radtriste reviewed Feb 8, 2023

View reviewed changes

MarianMacik reviewed Feb 8, 2023

View reviewed changes

MarianMacik approved these changes Feb 9, 2023

View reviewed changes

Incorporating PR comments

d76c562

akumar074 force-pushed the migrate-1.33.x branch from ca8d0a2 to d76c562 Compare February 10, 2023 07:38

add a note that the operator is community only

8f8c115

ricardozanini approved these changes Feb 10, 2023

View reviewed changes

Operator version fixed

e2f4980

ricardozanini approved these changes Feb 10, 2023

View reviewed changes

akumar074 requested a review from radtriste February 10, 2023 14:47

radtriste reviewed Feb 10, 2023

View reviewed changes

...es/serverless-logic/pages/cloud/build-and-deploy-with-serverless-operator-on-kubernetes.adoc Outdated Show resolved Hide resolved

Incorporating PR comments

872386d

radtriste approved these changes Feb 10, 2023

View reviewed changes

ricardozanini merged commit d415c44 into openshift-knative:master Feb 10, 2023

akumar074 deleted the migrate-1.33.x branch February 23, 2023 06:22

SRVLOGIC-75: Update openshift knative docs with Serverless Logic Workflow guides for 1.32.0 #89

SRVLOGIC-75: Update openshift knative docs with Serverless Logic Workflow guides for 1.32.0 #89

Uh oh!

Conversation

akumar074 commented Jan 31, 2023

Uh oh!

openshift-ci-robot commented Jan 31, 2023

Uh oh!

netlify bot commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jazzy-shortbread-5f62b7 ready!

Uh oh!

ricardozanini left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MarianMacik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

radtriste left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akumar074 commented Feb 2, 2023

Uh oh!

akumar074 commented Feb 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akumar074 commented Feb 9, 2023

Uh oh!

netlify bot commented Jan 31, 2023 •

edited

Loading