Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.12] imc dispatcher doesn't have duplicate reporting of metrics #595

Conversation

matzew
Copy link
Member

@matzew matzew commented Apr 26, 2024

fix: imc dispatcher doesn't have duplicate reporting

basically, porting back this PR: knative#7870

…ive#7870)

fix: imc dispatcher doesn't have duplicate reporting

Signed-off-by: Calum Murray <cmurray@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and creydr April 26, 2024 05:18
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented Apr 26, 2024

/cherry-pick release-v1.14

@openshift-cherrypick-robot

@matzew: once the present PR merges, I will cherry-pick it on top of release-v1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5d242f7 into openshift-knative:release-v1.12 Apr 26, 2024
6 checks passed
@openshift-cherrypick-robot

@matzew: new pull request created: #596

In response to this:

/cherry-pick release-v1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants