Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

kni-install isn't using the pinned rhcos version for masters #37

Closed
markmc opened this issue Apr 3, 2019 · 3 comments
Closed

kni-install isn't using the pinned rhcos version for masters #37

markmc opened this issue Apr 3, 2019 · 3 comments

Comments

@markmc
Copy link
Contributor

markmc commented Apr 3, 2019

openshift-install is currently built with a pinned build of rhcos. See e.g.

hack/build.sh:5:RHCOS_BUILD_NAME="${RHCOS_BUILD_NAME:-400.7.20190306.0}"

We currently properly use this image for the bootstrap VM launched with the libvirt provider:

        case baremetal.Name:
                osimage, err = rhcos.QEMU(ctx, rhcos.DefaultChannel)

This resolves to a URL in that channel for the QEMU image for that build as listed in meta.json at https://releases-rhcos.svc.ci.openshift.org/storage/releases

However, for the masters, we currently require that you pass that in via the following in install-config.yaml:

    master_configuration:
      image_source: "http://172.22.0.1/images/rhcos-maipo-latest.qcow2"
      image_checksum: 7656f23da8caf42142c0eafde22db096

and we generate this image in dev-scripts by taking the openstack qcow image and making a "dualdhcp" variant.

We should be working towards using an rhcos image for masters that is published in the official channels, and resolving the URL for that from published metadata like we do for the libvirt qcow.

@markmc
Copy link
Contributor Author

markmc commented May 7, 2019

The end goal here should probably be that bare-metal IPI fully manages the provisioning service for both master and worker deployment, including providing the correct RHCOS images to the provisioning service

i.e. openshift-install should download the RHCOS image and give it to Ironic. And longer-term when the a new release payload can update the bootimage in the installer-created MachineSets, in the bare-metal case it should download the new RHCOS image and give it to Ironic

@hardys
Copy link

hardys commented Jul 15, 2019

Note this should be fixed via #100

hardys pushed a commit to hardys/kni-installer that referenced this issue Jul 16, 2019
This shouldn't be hard-coded, so instead we replace the URL with the
appropriate data from rhcos.json.

Related: openshift-metal3#37
hardys pushed a commit to hardys/kni-installer that referenced this issue Jul 16, 2019
This shouldn't be hard-coded, so instead we replace the URL with the
appropriate data from rhcos.json.

Related: openshift-metal3#37
hardys pushed a commit to hardys/kni-installer that referenced this issue Jul 16, 2019
This shouldn't be hard-coded, so instead we replace the URL with the
appropriate data from rhcos.json.

Related: openshift-metal3#37
hardys pushed a commit to hardys/kni-installer that referenced this issue Jul 17, 2019
This shouldn't be hard-coded, so instead we replace the URL with the
appropriate data from rhcos.json.

Related: openshift-metal3#37
hardys pushed a commit to hardys/kni-installer that referenced this issue Jul 18, 2019
This shouldn't be hard-coded, so instead we replace the URL with the
appropriate data from rhcos.json.

Related: openshift-metal3#37
@russellb
Copy link
Member

moved to openshift/installer#2064

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants