Do not use a default revision in gatewayinstance tests #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test setup was creating two revisions where one was called default. In Istio 1.27 it resulted in two conflicting default tags which caused the echo workloads to be injected by incorrect control plane (gateway) which fails as it's not using CNI.
|
/retest |
|
The test was passing in release-1.26 because it does not contain a fix for istio/istio#56004. I'm still checking why there are two default tags because the new default tag for default revision should replace the default tag for non-default revision - https://github.com/istio/istio/blob/release-1.27/operator/pkg/webhook/webhook.go#L153 |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
fjglira
approved these changes
Sep 29, 2025
|
/retest |
2 similar comments
|
/retest |
|
/retest |
openshift-merge-bot
bot
merged commit 87def1c
into
openshift-service-mesh:release-1.27
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test setup was creating two revisions where one was called default. In Istio 1.27 (after istio/istio#56004) it resulted in two conflicting default tags which caused the echo workloads to be injected by incorrect control plane (gateway) which fails as it's not using CNI.
TAG REVISION NAMESPACES
default default
default gateway
istio-revision-tag-default-gateway... MutatingWebhookConfiguration was created for gateway revision (gateway namespace)
istio-revision-tag-default-mesh... MutatingWebhookConfiguration was created for default revision (mesh namespace)
Having both control planes in one namespace would result only in one default tag as it would be named the same and installation of second control plane would overwrite the existing default tag.
The fix is using proper revision names so there is no conflict.