Skip to content

Conversation

JoelSpeed
Copy link
Contributor

QE picked up this small error during testing. After various iterations of #1091 the name of this field was changed. It makes sense for it to be paritionNumber in a customer facing context

@JoelSpeed JoelSpeed force-pushed the fix-partition-number-tag branch from 93f271c to dc860bc Compare March 3, 2022 09:49
@JoelSpeed
Copy link
Contributor Author

As this project is not part of the no-ff process, I'll apply the labels manually

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Mar 3, 2022
@JoelSpeed JoelSpeed changed the title Correct json tag on AWS Placement PartitionNumber Bug 2060697: Correct json tag on AWS Placement PartitionNumber Mar 4, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@JoelSpeed: This pull request references Bugzilla bug 2060697, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @huali9

In response to this:

Bug 2060697: Correct json tag on AWS Placement PartitionNumber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from huali9 March 4, 2022 09:57
@huali9
Copy link

huali9 commented Mar 4, 2022

LGTM

@deads2k
Copy link
Contributor

deads2k commented Mar 4, 2022

eek
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@JoelSpeed
Copy link
Contributor Author

/test verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 654ca07 into openshift:master Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@JoelSpeed: All pull requests linked via external trackers have merged:

Bugzilla bug 2060697 has been moved to the MODIFIED state.

In response to this:

Bug 2060697: Correct json tag on AWS Placement PartitionNumber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants