-
Notifications
You must be signed in to change notification settings - Fork 574
Bug 2060697: Correct json tag on AWS Placement PartitionNumber #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2060697: Correct json tag on AWS Placement PartitionNumber #1131
Conversation
93f271c
to
dc860bc
Compare
As this project is not part of the no-ff process, I'll apply the labels manually /label docs-approved |
@JoelSpeed: This pull request references Bugzilla bug 2060697, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM |
eek |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test verify |
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@JoelSpeed: All pull requests linked via external trackers have merged: Bugzilla bug 2060697 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
QE picked up this small error during testing. After various iterations of #1091 the name of this field was changed. It makes sense for it to be
paritionNumber
in a customer facing context