OCPBUGS-12699: Add additional names to env var allow list

[coreydaley]

Adding additional env vars to the whitelist so that we can also set the proxy env vars in lowercase which is required by some well known tools such as CURL. I have also opened openshift/openshift-controller-manager#278 which will automatically set the lowercase env vars along with the uppercase ones.

[openshift-ci-robot]

@coreydaley: This pull request references Jira Issue OCPBUGS-12699, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hello @coreydaley! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coreydaley]

/jira refresh

[openshift-ci-robot]

@coreydaley: This pull request references Jira Issue OCPBUGS-12699, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @coreydaley

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: coreydaley.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@coreydaley: This pull request references Jira Issue OCPBUGS-12699, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @coreydaley

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@coreydaley: This pull request references Jira Issue OCPBUGS-12699, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @coreydaley

In response to this:

Adding additional env vars to the whitelist so that we can also set the proxy env vars in lowercase which is required by some well known tools such as CURL. I have also opened openshift/openshift-controller-manager#278 which will automatically set the lowercase env vars along with the uppercase ones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: coreydaley.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@coreydaley: This pull request references Jira Issue OCPBUGS-12699, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @coreydaley

In response to this:

Adding additional env vars to the whitelist so that we can also set the proxy env vars in lowercase which is required by some well known tools such as CURL. I have also opened openshift/openshift-controller-manager#278 which will automatically set the lowercase env vars along with the uppercase ones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coreydaley]

/assign @adambkaplan
Can you please take a look at this and give it an lgtm unless you have questions/concerns?
Then I will assign it to David to get merged.

[adambkaplan]

Potentially will result in a merge conflict with #1660?

[coreydaley]

I will rebase it after #1660 merges, but I wanted to keep them separate

[adambkaplan]

/hold

Per Corey's comment, can release once #1660 merges.

[coreydaley]

/hold cancel
/assign @bparees

[coreydaley]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@coreydaley: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bparees]

/approve

[coreydaley]

/retest-required

[coreydaley]

/assign @adambkaplan
for lgtm

[coreydaley]

@adambkaplan bump

[adambkaplan]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@coreydaley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@coreydaley: Jira Issue OCPBUGS-12699: Some pull requests linked via external trackers have merged:

• openshift/api#1659

The following pull requests linked via external trackers have not merged:

• openshift/openshift-controller-manager#278 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-12699 has not been moved to the MODIFIED state.

In response to this:

Adding additional env vars to the whitelist so that we can also set the proxy env vars in lowercase which is required by some well known tools such as CURL. I have also opened openshift/openshift-controller-manager#278 which will automatically set the lowercase env vars along with the uppercase ones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@coreydaley: #1659 failed to apply on top of branch "release-4.14":

Applying: OCPBUGS-12699: Add additional names to env var allow list
Using index info to reconstruct a base tree...
M	build/v1/consts.go
Falling back to patching base and 3-way merge...
Auto-merging build/v1/consts.go
CONFLICT (content): Merge conflict in build/v1/consts.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-12699: Add additional names to env var allow list
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.15.0-202311280834.p0.gd83ab5b.assembly.stream for distgit ose-cluster-config-api.
All builds following this will include this PR.