Bug 1732929: Pin dependencies to 4.1 #253

vikaschoudhary16 · 2019-08-22T10:40:39Z

Fixing:

https://bugzilla.redhat.com/show_bug.cgi?id=1713061 (Missing node prevents machine from being delete)
https://bugzilla.redhat.com/show_bug.cgi?id=1732929 (4.1.4 cluster creating 400+ eviction requests a second)
Pinning dependencies, cluster-api and cluster-api-actuator-pkg, to 4.1 release

Will rebase this PR once openshift/cluster-api-actuator-pkg#111 gets merged. This PR is further updating cluster-api-pkg-dependencies to 4.1 release

openshift-ci-robot · 2019-08-22T10:41:06Z

@vikaschoudhary16: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Use cluster api 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-08-23T12:50:42Z

@vikaschoudhary16: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Use cluster api 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelgugino

Looks like some dependencies are updated into 4.2 stuff.

michaelgugino · 2019-08-23T13:15:19Z

vendor/github.com/openshift/api/config/v1/types_infrastructure.go

This looks like 4.2 stuff.

eparis · 2019-08-24T18:43:28Z

We MUST have a 4.1.z target release bug in the title (of the form Bug NNNNNNN: title title title)
That bug MUST 'depend on' an 4.2 target release bz.
And that 4.2 BZ MUST be VERIFIED by QE.
We also need lgtm and approved from the team after review.

openshift-ci-robot · 2019-08-26T09:47:34Z

@vikaschoudhary16: This pull request references Bugzilla bug 1732929, which is invalid:

expected dependent Bugzilla bug 1733708 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1732929: Use cluster api 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikaschoudhary16 · 2019-08-26T09:50:50Z

We MUST have a 4.1.z target release bug in the title (of the form Bug NNNNNNN: title title title)
That bug MUST 'depend on' an 4.2 target release bz.
And that 4.2 BZ MUST be VERIFIED by QE.
We also need lgtm and approved from the team after review.

Updated. 4.2 bug is "ON_QA" so will wait till that gets "VERIFIED".

vikaschoudhary16 · 2019-08-26T12:17:26Z

/retest

openshift-ci-robot · 2019-08-27T07:01:12Z

@vikaschoudhary16: This pull request references Bugzilla bug 1732929, which is invalid:

expected dependent Bugzilla bug 1733708 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1732929: Use cluster api 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikaschoudhary16 · 2019-08-27T08:37:14Z

/test e2e-aws-operator

vikaschoudhary16 · 2019-08-28T11:16:45Z

/test e2e-aws-operator

ingvagabund · 2019-08-28T12:21:43Z

/bugzilla refresh

openshift-ci-robot · 2019-08-28T12:21:47Z

@ingvagabund: This pull request references Bugzilla bug 1732929, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Use openshift-4.1-cluster-api-0.0.0-alpha.4 Pin cluster-api-actuator-pkg to release-4.1

ingvagabund · 2019-08-28T13:57:17Z

/approve

openshift-ci-robot · 2019-08-28T13:57:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre · 2019-09-16T08:07:03Z

/retest

knobunc · 2019-09-16T12:55:16Z

/retest

openshift-bot · 2019-09-16T14:12:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-16T15:30:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-09-16T15:45:15Z

@knobunc: The label(s) /label cherry-pick-approved cannot be appled. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2019-09-16T16:48:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

knobunc · 2019-09-16T18:03:34Z

@vikaschoudhary16 I'm pulling approval for the backport until the tests pass. I tried a few times and I think it's a problem with the PR.

openshift-bot · 2019-09-16T18:32:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-16T18:45:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-16T20:16:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-16T21:34:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-16T22:39:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-16T23:57:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-17T01:15:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-17T02:33:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-17T03:51:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-17T05:09:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-17T06:14:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-17T07:19:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-17T08:24:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-17T08:37:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ingvagabund · 2019-09-17T09:53:42Z

From https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-aws/253/pull-ci-openshift-cluster-api-provider-aws-release-4.1-e2e-aws-operator/111/artifacts/e2e-aws-operator/pods/openshift-machine-api_machine-api-controllers-579b8c845b-427sv_machine-controller.log:

I0917 09:36:16.493790       1 controller.go:227] Machine "machine1" deletion successful

From https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-aws/253/pull-ci-openshift-cluster-api-provider-aws-release-4.1-e2e-aws-operator/111/artifacts/e2e-aws-operator/container-logs/test.log:

E0917 09:35:39.750590    6102 infra.go:464] Machine "machine1" not yet deleted
I0917 09:35:39.750938    6102 infra.go:365] Deleting object "pdb"

Machine machine1 was deleted eventually, it just happened 37s after the timeout.

openshift-bot · 2019-09-17T09:55:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ingvagabund · 2019-09-17T13:12:51Z

/retest

openshift-ci-robot · 2019-09-19T19:49:05Z

@vikaschoudhary16: All pull requests linked via external trackers have merged. Bugzilla bug 1732929 has been moved to the MODIFIED state.

In response to this:

Bug 1732929: Pin dependencies to 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-09-19T19:55:16Z

@vikaschoudhary16: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-upgrade	`d8a62dd`	link	`/test e2e-aws-upgrade`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 22, 2019

openshift-ci-robot requested review from enxebre and michaelgugino August 22, 2019 10:41

vikaschoudhary16 force-pushed the use-cluster-api-4.1 branch 2 times, most recently from ef96bc6 to 6b76b83 Compare August 23, 2019 12:48

michaelgugino suggested changes Aug 23, 2019

View reviewed changes

michaelgugino reviewed Aug 23, 2019

View reviewed changes

vendor/github.com/openshift/api/config/v1/types_infrastructure.go Outdated

Copy link

michaelgugino Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like 4.2 stuff.

vikaschoudhary16 changed the title ~~Use cluster api 4.1~~ Bug 1732929: Use cluster api 4.1 Aug 26, 2019

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 26, 2019

vikaschoudhary16 force-pushed the use-cluster-api-4.1 branch from 6b76b83 to 77981d9 Compare August 27, 2019 06:57

vikaschoudhary16 changed the title ~~Bug 1732929: Use cluster api 4.1~~ Bug 1732929: Pin dependencies to 4.1 Aug 27, 2019

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 28, 2019

vikaschoudhary16 force-pushed the use-cluster-api-4.1 branch from 77981d9 to f2aa263 Compare August 28, 2019 12:53

Pin dependencies to 4.1

d8a62dd

Use openshift-4.1-cluster-api-0.0.0-alpha.4 Pin cluster-api-actuator-pkg to release-4.1

vikaschoudhary16 force-pushed the use-cluster-api-4.1 branch from f2aa263 to d8a62dd Compare August 28, 2019 13:44

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2019

openshift deleted a comment from openshift-ci-robot Sep 16, 2019

knobunc removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 16, 2019

bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 19, 2019

openshift-merge-robot merged commit 9fe3645 into openshift:release-4.1 Sep 19, 2019

Bug 1732929: Pin dependencies to 4.1 #253

Bug 1732929: Pin dependencies to 4.1 #253

Uh oh!

Conversation

vikaschoudhary16 commented Aug 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 22, 2019

Uh oh!

openshift-ci-robot commented Aug 23, 2019

Uh oh!

michaelgugino left a comment

Choose a reason for hiding this comment

Uh oh!

michaelgugino Aug 23, 2019

Choose a reason for hiding this comment

Uh oh!

eparis commented Aug 24, 2019

Uh oh!

openshift-ci-robot commented Aug 26, 2019

Uh oh!

vikaschoudhary16 commented Aug 26, 2019

Uh oh!

vikaschoudhary16 commented Aug 26, 2019

Uh oh!

openshift-ci-robot commented Aug 27, 2019

Uh oh!

vikaschoudhary16 commented Aug 27, 2019

Uh oh!

vikaschoudhary16 commented Aug 28, 2019

Uh oh!

ingvagabund commented Aug 28, 2019

Uh oh!

openshift-ci-robot commented Aug 28, 2019

Uh oh!

ingvagabund commented Aug 28, 2019

Uh oh!

openshift-ci-robot commented Aug 28, 2019

Uh oh!

enxebre commented Sep 16, 2019

Uh oh!

knobunc commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

openshift-ci-robot commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

knobunc commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 16, 2019

Uh oh!

openshift-bot commented Sep 17, 2019

Uh oh!

openshift-bot commented Sep 17, 2019

Uh oh!

openshift-bot commented Sep 17, 2019

Uh oh!

openshift-bot commented Sep 17, 2019

Uh oh!

openshift-bot commented Sep 17, 2019

Uh oh!

openshift-bot commented Sep 17, 2019

Uh oh!

openshift-bot commented Sep 17, 2019

Uh oh!

openshift-bot commented Sep 17, 2019

vikaschoudhary16 commented Aug 22, 2019 •

edited

Loading