Skip to content

Conversation

jcantrill
Copy link
Contributor

… required

Description

This PR:

  • corrects API documentation and validation so pipeline.name is required as it has been since the introduction of CLF

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2023

@jcantrill: This pull request references LOG-4105 which is a valid jira issue.

In response to this:

… required

Description

This PR:

  • corrects API documentation and validation so pipeline.name is required as it has been since the introduction of CLF

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2023
@jcantrill
Copy link
Contributor Author

/cherrypick master

@openshift-cherrypick-robot

@jcantrill: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from cahartma and syedriko May 22, 2023 20:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@vparfonov
Copy link
Contributor

vparfonov commented May 24, 2023

/retitle LOG-4105: fix api documentation and validation where pipeline.name is required

@openshift-ci openshift-ci bot changed the title LOG-4105: fix api documentation and validation where pipeline.name is… LOG-4105: fix api documentation and validation where pipeline.name is required May 24, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c2173bb and 2 for PR HEAD 2ad71ce in total

@vparfonov
Copy link
Contributor

/test lint

2 similar comments
@vparfonov
Copy link
Contributor

/test lint

@vparfonov
Copy link
Contributor

/test lint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@jcantrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional-target 2ad71ce link false /test functional-target
ci/prow/lint 2ad71ce link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill jcantrill closed this May 25, 2023
@jcantrill jcantrill deleted the log4105 branch May 25, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants