Skip to content

LOG-4743: Refactor vector config generation to dynamically wire #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

LOG-4743: Refactor vector config generation to dynamically wire #2268

merged 1 commit into from
Dec 5, 2023

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • Modifies the vector config generation to wire components based upon the CLF pipelines

Links

@jcantrill
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@openshift-ci openshift-ci bot requested review from syedriko and vparfonov November 22, 2023 21:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@jcantrill jcantrill force-pushed the log4772 branch 3 times, most recently from cf3c057 to 0c02c84 Compare November 30, 2023 20:39
@jcantrill jcantrill changed the title Log4772 LOG-4743: Refactor vector config generation to dynamically wire Nov 30, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 30, 2023 •
edited by openshift-ci bot
Loading

@jcantrill: This pull request references LOG-4743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • Modifies the vector config generation to wire components based upon the CLF pipelines

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@jcantrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 631b28d link false /test functional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

alanconway
alanconway approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit bd3b77d into openshift:master Dec 5, 2023
@jcantrill jcantrill deleted the log4772 branch December 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syedriko syedriko Awaiting requested review from syedriko

@vparfonov vparfonov Awaiting requested review from vparfonov

1 more reviewer

@alanconway alanconway alanconway approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@alanconway alanconway

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcantrill @openshift-ci-robot @alanconway