-
Notifications
You must be signed in to change notification settings - Fork 165
WIP: LOG-4445: Forwarder must use hosted cluster_id on HCP cluster. #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alanconway: This pull request references LOG-4445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
@alanconway I would additionally rebase this against 5.8 since we are delivering their first |
@alanconway: This pull request references LOG-4445 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c019527
to
281eaf8
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
NOTE: Using unstructured objects for HCP because of dependency problems with the hypershift API package. When https://issues.redhat.com/browse/HOSTEDCP-336 is fixed, switch to static approach. Code in ./_clusterinfo_static
281eaf8
to
8439838
Compare
@alanconway: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alanconway: Failed to re-open PR: state cannot be changed. The hypershift-cluster-id branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.