Skip to content

Conversation

alanconway
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023

@alanconway: This pull request references LOG-4445 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from Clee2691 and vparfonov November 29, 2023 01:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@jcantrill
Copy link
Contributor

/hold

@jcantrill
Copy link
Contributor

@alanconway I would additionally rebase this against 5.8 since we are delivering their first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@alanconway alanconway changed the base branch from master to release-5.8 November 29, 2023 21:57
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023

@alanconway: This pull request references LOG-4445 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2023
@alanconway alanconway force-pushed the hypershift-cluster-id branch from c019527 to 281eaf8 Compare November 29, 2023 22:34
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2023
@openshift-ci openshift-ci bot added the midstream/Dockerfile A Dockerfile.in sync is needed with midstream label Nov 29, 2023
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

NOTE: Using unstructured objects for HCP because of dependency problems with the hypershift API package.
When https://issues.redhat.com/browse/HOSTEDCP-336 is fixed, switch to static approach.
Code in ./_clusterinfo_static
@alanconway alanconway force-pushed the hypershift-cluster-id branch from 281eaf8 to 8439838 Compare November 29, 2023 22:43
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@alanconway: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-target-minus-two 8439838 link false /test e2e-ocp-target-minus-two
ci/prow/e2e-target 8439838 link true /test e2e-target
ci/prow/e2e-ocp-target-minus-one 8439838 link false /test e2e-ocp-target-minus-one

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alanconway alanconway changed the title LOG-4445: Forwarder must use hosted cluster_id on HCP cluster. WIP: LOG-4445: Forwarder must use hosted cluster_id on HCP cluster. Dec 5, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2023
@alanconway alanconway closed this Dec 6, 2023
@alanconway alanconway deleted the hypershift-cluster-id branch December 6, 2023 14:05
Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@alanconway: Failed to re-open PR: state cannot be changed. The hypershift-cluster-id branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. midstream/Dockerfile A Dockerfile.in sync is needed with midstream release/5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants