LOG-5748: Include additional API declarative validations #2606
Conversation
|
@jcantrill: This pull request references LOG-5748 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
jcantrill
added
release/6.0
and removed
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
| ) | ||
|
|
||
| // FilterSpec defines a filter for log messages. | ||
| // +kubebuilder:validation:XValidation:rule="self.type != 'kubeAPIAudit' || has(self.kubeAPIAudit)", message="Additional type specific spec is required for the filter type" |
There was a problem hiding this comment.
nit: Maybe make sense to add filter type name to the validation message to be more clear
| ) | ||
|
|
||
| // OutputSpec defines a destination for log messages. | ||
| // +kubebuilder:validation:XValidation:rule="self.type != 'azureMonitor' || has(self.azureMonitor)", message="Additional type specific spec is required for the output type" |
There was a problem hiding this comment.
nit: Maybe make sense to add output type name to the validation message to be more clear
|
/lgtm |
|
@jcantrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR:
Links
https://issues.redhat.com/browse/LOG-5748
cc @cahartma @Clee2691