LOG-5810: fix cloudwatch stream names

[cahartma]

Description

All app logs in cloudwatch had their stream_name set to default. This was caused by the del(.file) we are putting in each log_type filter. I've created ._internal.file to store the filename and modified the cloudwatch stream_name assignment.
Two small changes, then the remaining files are .toml files for testing.

note: No records are dropped if either of these fields (.file, .message) is not present. I am curious though, what other sinks could have been sending .file previously? other output types?

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

https://issues.redhat.com/browse/LOG-5807

[openshift-ci-robot]

@cahartma: This pull request references LOG-5810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

All app logs in cloudwatch had their stream_name set to default. This was caused by the del(.file) we are putting in each log_type filter. I've created ._internal.file` to store the filename and modified the cloudwatch stream_name assignment.
Two small changes, then the remaining files are .toml files for testing.

note: No records are dropped if either of these fields (.file, .message) is not present. I am curious though, what other sinks could have been sending .file previously? other output types?

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

https://issues.redhat.com/browse/LOG-5807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cahartma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@cahartma: This pull request references LOG-5810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

All app logs in cloudwatch had their stream_name set to default. This was caused by the del(.file) we are putting in each log_type filter. I've created ._internal.file to store the filename and modified the cloudwatch stream_name assignment.
Two small changes, then the remaining files are .toml files for testing.

note: No records are dropped if either of these fields (.file, .message) is not present. I am curious though, what other sinks could have been sending .file previously? other output types?

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

https://issues.redhat.com/browse/LOG-5807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcantrill]

This is what we did previously and I'm not certain where "file" is needed other then "tag" comes from the source file. File or tag can be replaced by the combination of log_type and log_source.

  if ( .log_type == "application" ) {
   .group_name = ( "` + groupPrefix + `." + .log_type ) ?? "application"
  }
  if ( .log_type == "audit" ) {
   .group_name = "` + groupPrefix + `.audit"
   .stream_name = ( "${VECTOR_SELF_NODE_NAME}" + .tag ) ?? .stream_name
  }
  if ( .log_type == "infrastructure" ) {
   .group_name = "` + groupPrefix + `.infrastructure"
   .stream_name = ( .hostname + "." + .stream_name ) ?? .stream_name
  }

We need to reconsider what our defaults are and probably intialize them accordingly

[cahartma]

There are a few lines above that, or you have different code than me:

.stream_name = "default"

if ( .file != null) {
 .stream_name = "kubernetes" + replace!(.file, "/", ".")
}

[jcantrill]

/retest
/lgtm

[jcantrill]

/refresh

[openshift-ci]

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.