Skip to content

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • refactors the HTTP content type validation to observability api

Links

https://issues.redhat.com/browse/LOG-5816

cc @vparfonov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2024

@jcantrill: This pull request references LOG-5816 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • refactors the HTTP content type validation to observability api

Links

https://issues.redhat.com/browse/LOG-5816

cc @vparfonov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill jcantrill added release/6.0 and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 16, 2024
@openshift-ci openshift-ci bot requested review from alanconway and vparfonov July 16, 2024 21:16
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1ed115b into openshift:master Jul 17, 2024
@jcantrill jcantrill deleted the log5816 branch July 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants