Skip to content

LOG-5820: Refactor filter validation to OBS #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

LOG-5820: Refactor filter validation to OBS #2661

merged 1 commit into from
Jul 25, 2024

Conversation

jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Jul 17, 2024 •
edited
Loading

Description

This PR:

  • refactors the filter validations to the observability API
  • Adds declarative API to block upon creation

Links

cc @Clee2691 @cahartma @vparfonov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2024 •
edited by openshift-ci bot
Loading

@jcantrill: This pull request references LOG-5820 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR: refactors the filter validations to the observability API

Links

https://issues.redhat.com/browse/LOG-5820

cc @Clee2691 @cahartma @vparfonov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill jcantrill added release/6.0 and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 17, 2024
@openshift-ci openshift-ci bot requested review from cahartma and Clee2691 July 17, 2024 17:13
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@jcantrill
Copy link
Contributor Author

/test e2e-target

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2024
@cahartma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d21d2b6 and 2 for PR HEAD 606bb26 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e7a8a13 and 1 for PR HEAD 606bb26 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4f1c9fc and 0 for PR HEAD 606bb26 in total

@openshift-ci-robot
Copy link

/hold

Revision 606bb26 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2024
@jcantrill
Copy link
Contributor Author

/test e2e-target

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@jcantrill
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2024
@jcantrill
Copy link
Contributor Author

/retest

@cahartma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 169f3b3 and 2 for PR HEAD 0c436da in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f975322 and 1 for PR HEAD 0c436da in total

@jcantrill
Copy link
Contributor Author

/retest

@cahartma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 310a9cd and 2 for PR HEAD 6e53f1e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1db0661 and 1 for PR HEAD 6e53f1e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c909071 and 0 for PR HEAD 6e53f1e in total

@openshift-ci-robot
Copy link

/hold

Revision 6e53f1e was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
@cahartma
Copy link
Contributor

@jcantrill okay to override this test failure?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@jcantrill
Copy link
Contributor Author

@cahartma updated to resolve a CRD install issue

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
@cahartma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1c607cd and 2 for PR HEAD 41e30aa in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@jcantrill
LOG-5823: Refactor kafka URL validation to obs API
c9d5411 
LOG-5824: Refactor syslog URL validation to obs
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@cahartma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e0e369 and 2 for PR HEAD c9d5411 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 97f154e and 1 for PR HEAD c9d5411 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 43fc741 into openshift:master Jul 25, 2024
@jcantrill jcantrill deleted the log5820 branch July 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clee2691 Clee2691 Awaiting requested review from Clee2691

1 more reviewer

@cahartma cahartma cahartma left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@cahartma cahartma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcantrill @openshift-ci-robot @cahartma @openshift-merge-robot