LOG-5602: Vector forwarding auth issue when password contains $ #2755
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Clee2691: This pull request references LOG-5602 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| port = o.Value | ||
| } | ||
| err = wait.PollUntilContextTimeout(context.TODO(), defaultRetryInterval, maxDuration, true, func(cxt context.Context) (done bool, err error) { | ||
| cmd := `curl -u ` + `'` + username + `'` + `:` + `'` + password + `' ` + `-X GET "localhost:` + port + `/` + index + `/_search?pretty" -H 'Content-Type: application/json' -d' |
There was a problem hiding this comment.
I think this would be cleaner and easier to read using Sprintf
| } | ||
| } | ||
| '` | ||
| fmt.Println(cmd) |
There was a problem hiding this comment.
print statement. replace with log statement
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Clee2691, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
/test functional-target |
1 similar comment
|
/test functional-target |
|
@Clee2691: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Description
This PR fixes vector config generation where fields configured with
$were expecting and environment variable. Instead it now escapes$with$$./cc @cahartma @vparfonov
/assign @jcantrill
Links