Skip to content

Conversation

jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Aug 15, 2024

Description

This change:

  • reverts some of the behavior from LOG-4536 to block when the buffer is full

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 15, 2024

@jcantrill: This pull request references LOG-4597 which is a valid jira issue.

In response to this:

Description

This change:

  • reverts some of the behavior from LOG-4536 to block when the buffer is full

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill jcantrill added release/5.8 and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 15, 2024

@jcantrill: This pull request references LOG-4597 which is a valid jira issue.

In response to this:

Description

This change:

  • reverts some of the behavior from LOG-4536 to block when the buffer is full

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 15, 2024
@openshift-ci openshift-ci bot requested review from alanconway and cahartma August 15, 2024 20:34
Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Clee2691
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e4279a4 into openshift:release-5.8 Aug 16, 2024
@jcantrill jcantrill deleted the log4902 branch August 19, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants