Skip to content

LOG-6069: Enable http/https proxy support for HTTP output. #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

LOG-6069: Enable http/https proxy support for HTTP output. #2798

merged 1 commit into from
Dec 2, 2024
+76 −18

Conversation

alanconway
Copy link
Contributor

@alanconway alanconway commented Sep 10, 2024 •
edited by openshift-ci bot
Loading

Description

Add a 'proxy' field to HTTP output configuration to enable use of a proxy.e! -->

/cc @jcantrill
/assign @jcantrill

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2024 •
edited by openshift-ci bot
Loading

@alanconway: This pull request references LOG-6069 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

In response to this:

Description

Add a 'proxy' field to HTTP output configuration to enable use of a proxy.e! -->

/cc @jcantrill
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2024
@openshift-ci openshift-ci bot requested a review from jcantrill September 10, 2024 20:37
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2024 •
edited by openshift-ci bot
Loading

@alanconway: This pull request references LOG-6069 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

In response to this:

Description

Add a 'proxy' field to HTTP output configuration to enable use of a proxy.e! -->

/cc @jcantrill
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@jcantrill
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2024
jcantrill
jcantrill reviewed Sep 11, 2024
View reviewed changes
samanthajayasinghe
samanthajayasinghe reviewed Sep 30, 2024
View reviewed changes
@alanconway alanconway force-pushed the http-proxy branch 3 times, most recently from 72c696d to 41ff4fc Compare October 15, 2024 14:17
@alanconway
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@jcantrill
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@alanconway
Copy link
Contributor Author

Waiting on @jcantrill to resolve release questions.

jcantrill
jcantrill reviewed Oct 17, 2024
View reviewed changes
@jcantrill
Copy link
Contributor

/hold cancel

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2024
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7fc8ed9 into openshift:master Dec 2, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

+1 more reviewer

@samanthajayasinghe samanthajayasinghe samanthajayasinghe left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alanconway @openshift-ci-robot @jcantrill @samanthajayasinghe @openshift-merge-robot