Skip to content

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Oct 8, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@vparfonov: This pull request references LOG-4671 which is a valid jira issue.

In response to this:

Reverts #2802

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cahartma and Clee2691 October 8, 2024 09:43
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@vparfonov: This pull request references LOG-4671 which is a valid jira issue.

In response to this:

Reverts #2802 because zero is not valid value, see: https://github.com/vectordotdev/vector/blob/b58e1b22cff3c80abff1ac30a63f7bb638a8848f/src/transforms/throttle.rs#L227

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vparfonov
Copy link
Contributor Author

/assign @jcantrill

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@vparfonov: This pull request references LOG-4671 which is a valid jira issue.

In response to this:

Reverts #2802 because zero is not valid value, see: https://github.com/vectordotdev/vector/blob/b58e1b22cff3c80abff1ac30a63f7bb638a8848f/src/transforms/throttle.rs#L227

Open PR with validation: #2817

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill
Copy link
Contributor

/approve
/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f3b5346 into openshift:release-5.8 Oct 8, 2024
10 checks passed
@vparfonov vparfonov deleted the revert-2802-log4671 branch October 8, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants