LOG-6573: Require namespace for LokiStack target

[jcantrill]

Description

This PR:

• updates the LokiStack output type api to require setting the target namespace of the loki deployment
• Modifies the comments to no longer imply the operator defaults anything

Links

https://issues.redhat.com/browse/LOG-6573

[openshift-ci-robot]

@jcantrill: This pull request references LOG-6573 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

• updates the LokiStack output type api to require setting the target namespace of the loki deployment
• Modifies the comments to no longer imply the operator defaults anything

Links

https://issues.redhat.com/browse/LOG-6573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcantrill]

/cherrypick release-6.1

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@jcantrill: once the present PR merges, I will cherry-pick it on top of release-6.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jcantrill]

/retest

[openshift-ci]

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Clee2691]

/lgtm

[openshift-cherrypick-robot]

@jcantrill: #2922 failed to apply on top of branch "release-6.1":

Applying: LOG-6573: Require namespace for LokiStack target
error: patch failed: docs/reference/operator/api_observability_v1.adoc:2127
error: docs/reference/operator/api_observability_v1.adoc: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
M	api/observability/v1/output_types.go
M	bundle/manifests/cluster-logging.clusterserviceversion.yaml
M	bundle/manifests/observability.openshift.io_clusterlogforwarders.yaml
M	config/crd/bases/observability.openshift.io_clusterlogforwarders.yaml
M	config/manifests/bases/cluster-logging.clusterserviceversion.yaml
M	docs/reference/operator/api_observability_v1.adoc
Patch failed at 0001 LOG-6573: Require namespace for LokiStack target

In response to this:

/cherrypick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.