Skip to content

[release-5.9]LOG-7009: avoid merge data from .message field to the log event root #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

[release-5.9]LOG-7009: avoid merge data from .message field to the log event root #3035

merged 1 commit into from
May 16, 2025

Conversation

vparfonov
Copy link
Contributor

Description

This PR addresses several issues introduced during the migration from Fluentd to Vector, particularly related to how the.message field was merged into the log event.

These issues include:

  • Overwriting important system fields
  • Duplication of data
  • Corruption of log events due to improper structure

With this change, the .message field is replaced if it will valid JSON string, with structured data instead of being blindly merged. This enables correct handling of nested fields during the Syslog encoding process in Vector.

/cc @Clee2691 @cahartma
/assign @jcantrill

Links

@vparfonov
LOG-7009: avoid merge data from message to the log event
4f71583 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025 •
edited by openshift-ci bot
Loading

@vparfonov: This pull request references LOG-7009 which is a valid jira issue.

In response to this:

Description

This PR addresses several issues introduced during the migration from Fluentd to Vector, particularly related to how the.message field was merged into the log event.

These issues include:

  • Overwriting important system fields
  • Duplication of data
  • Corruption of log events due to improper structure

With this change, the .message field is replaced if it will valid JSON string, with structured data instead of being blindly merged. This enables correct handling of nested fields during the Syslog encoding process in Vector.

/cc @Clee2691 @cahartma
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cahartma and Clee2691 May 6, 2025 18:09
@vparfonov
Copy link
Contributor Author

/hold until ViaQ/vector#203

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2025
@vparfonov
Copy link
Contributor Author

/assign @jcantrill

@vparfonov vparfonov changed the title LOG-7009: avoid merge data from message to the log event LOG-7009: avoid merge data from .message field to the log event May 6, 2025
@vparfonov
Copy link
Contributor Author

/test functional-target

@vparfonov
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2025
@vparfonov
Copy link
Contributor Author

/test functional-target

3 similar comments
@vparfonov
Copy link
Contributor Author

/test functional-target

@vparfonov
Copy link
Contributor Author

/test functional-target

@vparfonov
Copy link
Contributor Author

/test functional-target

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2025

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vparfonov vparfonov changed the title LOG-7009: avoid merge data from .message field to the log event LOG-7009: avoid merge data from .message field to the log event root May 8, 2025
@jcantrill
Copy link
Contributor

/hold
/approve
/lgtm

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2025
@vparfonov vparfonov changed the title LOG-7009: avoid merge data from .message field to the log event root [release-5.9]LOG-7009: avoid merge data from .message field to the log event root May 13, 2025
@jcantrill
Copy link
Contributor

@vparfonov release the hold once the current z-stream hold is lifted

@vparfonov
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3cd94e5 into openshift:release-5.9 May 16, 2025
7 checks passed
@vparfonov vparfonov deleted the log7009_3_5.9 branch May 28, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahartma cahartma Awaiting requested review from cahartma

@Clee2691 Clee2691 Awaiting requested review from Clee2691

Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vparfonov @openshift-ci-robot @jcantrill