LOG-7196: Enable annotations for kubeapi caching and configurable maxUnavailable

[cahartma]

Description

This feature adds the use_apiserver_cache config to the vector.toml and a configurable rollout strategy maxUnavailable to the DS.
Both of these are currently enabled via annotations in the CLF. Future effort will move these to the forwarder spec.

Verifying

Besides collector conditions and status, the following commands can be used to verify the two options:
oc get cm/my-forwarder-config -o jsonpath='{.data.vector\.toml}' |grep use_apiserver_cache
oc get ds/my-forwarder -oyaml -o jsonpath='{.spec.updateStrategy.rollingUpdate.maxUnavailable}'

/cc @Clee2691 @vparfonov @jcantrill
/assign @xperimental

Links

• https://issues.redhat.com/browse/LOG-7196

[openshift-ci-robot]

@cahartma: This pull request references LOG-7196 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This feature adds the use_apiserver_cache config to the vector.toml and a configurable rollout strategy maxUnavailable to the DS.
Both of these are currently enabled via annotations in the CLF. Future effort will move these to the forwarder spec.

Verifying

Besides collector conditions and status, the following commands can be used to verify the two options:
oc get cm/my-forwarder-config -o jsonpath='{.data.vector\.toml}' |grep use_apiserver_cache
oc get ds/my-forwarder -oyaml -o jsonpath='{.spec.updateStrategy.rollingUpdate.maxUnavailable}'

/cc @Clee2691 @vparfonov @jcantrill
/assign @xperimental

Links

• https://issues.redhat.com/browse/LOG-7196

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cahartma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[anpingli]

Run some test to-cloudwatch and to-lokistack. the Vector works well when use_apiserver_cache enabled.
The DaemonSet rollingUpdate.maxUnavailable is set as what .spec.updateStrategy.rollingUpdate.maxUnavailable is specified.

[cahartma]

... as what .spec.updateStrategy.rollingUpdate.maxUnavailable is specified.

@anpingli instead do you mean it matches the value set in the annotation?

[openshift-ci]

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[vparfonov]

/lgtm