OCPBUGS-62153: E2E: skip SMT disabled test when L3 cache spans entire NUMA node #1397
Conversation
mrniranjan
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-62153, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-62153, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-62153, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
While the LLC code will do nothing on VMs, it should still work and pass, right? |
On VM's we don't have any Uncore cache and niether the VM's on which tests run have any huge number of cpus. Also these vms are created only intel systems which are old (dell 640/750) . |
Correct but the vm's on which the D/S tests run, they are created on old Intel only dell hardware. And these vm's don't have huge number of cpu's or memory and neither the L3 cache on these hardware is huge enough to map them on vm's. |
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Niranjan M.R <mniranja@redhat.com>
mrniranjan
force-pushed
the
skip_llc_vm
branch
from
a0ccadb to
51e7a7f
Compare
mrniranjan
changed the title
| if len(numaInfo[0]) == L3CacheGroupSize { | ||
| Skip("This test requires systems where L3 cache is shared amount subset of cpus") | ||
| } |
There was a problem hiding this comment.
this should work, but (much) better would be to match the cpusets ID by ID
There was a problem hiding this comment.
fixed in latest commit
Signed-off-by: Niranjan M.R <mniranja@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, mrniranjan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/test okd-scos-e2e-aws-ovn |
|
/retest |
1 similar comment
|
/retest |
|
@mrniranjan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @mrniranjan |
openshift-ci-robot
added
the
verified
|
@mrniranjan: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit edea888
into
openshift:main
|
@mrniranjan: Jira Issue Verification Checks: Jira Issue OCPBUGS-62153 Jira Issue OCPBUGS-62153 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.20 |
|
@mrniranjan: new pull request created: #1404 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The earlier pr openshift#1397 used to compare if the cpus returned by ccx are same as numa node 0, which may not be same, even though the size matches. This cause the test to not skip on vm. Signed-off-by: Niranjan M.R <mniranja@redhat.com>
The earlier pr openshift#1397 used to compare if the cpus returned by ccx are same as numa node 0, which may not be same, even though the size matches. This cause the test to not skip on vm. Signed-off-by: Niranjan M.R <mniranja@redhat.com>
The earlier pr openshift#1397 used to compare if the cpus returned by ccx are same as numa node 0, which may not be same, even though the size matches. This cause the test to not skip on vm. Signed-off-by: Niranjan M.R <mniranja@redhat.com>
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-07-102242 |
Skipping LLC tests on virtual machines as these
dont have uncore cache similar to Baremetal systems