Skip to content

[release-4.20] OCPBUGS-62214: E2E: Add function to check control plane nodes are schedulable. #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 2, 2025
Merged

[release-4.20] OCPBUGS-62214: E2E: Add function to check control plane nodes are schedulable. #1398

merged 5 commits into from
Oct 2, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1396

/assign mrniranjan

@mrniranjan
Add function to check control plane is schedulable
27dec8d 
Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@mrniranjan
Skip Node selector tests when control planes are schedulable
3bb4fef 
Skip Node selector tests when control plane
nodes are schedulable since this tests primarily adds
and deletes mcp on worker nodes and modifies the performance
profile appropriately. This test is not applicable
when control plane nodes are schedulable and we
are relying on performance profile applied to control plane nodes

Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@mrniranjan
Use openshift api to fetch control plane nodes schedulable info
8d30a26 
Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@mrniranjan
Get rest config required to access api server
516d0e8 
Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@mrniranjan
Pass context.TODO() to IsControlPlaneSchedulable function
edfbe28 
Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-62091 has been cloned as Jira Issue OCPBUGS-62214. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-62214: E2E: Add function to check control plane nodes are schedulable.

In response to this:

This is an automated cherry-pick of #1396

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-62091: E2E: Add function to check control plane nodes are schedulable. [release-4.20] OCPBUGS-62214: E2E: Add function to check control plane nodes are schedulable. Sep 25, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 25, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-62214, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-62091 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-62091 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1396

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yanirq
Copy link
Contributor

yanirq commented Oct 2, 2025

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 2, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2025
@mrniranjan
Copy link
Contributor

/verified by @mrniranjan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 2, 2025
@openshift-ci-robot
Copy link
Contributor

@mrniranjan: This PR has been marked as verified by @mrniranjan.

In response to this:

/verified by @mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MarSik
MarSik approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, openshift-cherrypick-robot, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4463f9b and 2 for PR HEAD edfbe28 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b593115 into openshift:release-4.20 Oct 2, 2025
18 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-62214
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62214 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This is an automated cherry-pick of #1396

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.20.0-0.nightly-2025-10-03-170258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrniranjan mrniranjan Awaiting requested review from mrniranjan

@Tal-or Tal-or Awaiting requested review from Tal-or

@yanirq yanirq Awaiting requested review from yanirq

1 more reviewer

@MarSik MarSik MarSik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@MarSik MarSik

@mrniranjan mrniranjan

@yanirq yanirq

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @yanirq @mrniranjan @openshift-merge-robot @MarSik