Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases to detect invalid version histories #101

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Jan 24, 2019

The CVO is reporting history entries back to back that have the same
image and version. Add an integration test to check the status of the
history.

    history:
    - completionTime: null
      image: registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-24-174342
      startedTime: 2019-01-24T22:31:00Z
      state: Partial
      version: 4.0.0-0.alpha-2019-01-24-174342
    - completionTime: 2019-01-24T22:31:00Z
      image: registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-24-164957
      startedTime: 2019-01-24T22:00:40Z
      state: Completed
      version: 4.0.0-0.alpha-2019-01-24-164957
    - completionTime: 2019-01-24T22:00:40Z
      image: registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-24-164957
      startedTime: 2019-01-24T21:59:53Z
      state: Partial
      version: 4.0.0-0.alpha-2019-01-24-164957
    - completionTime: 2019-01-24T21:59:53Z
      image: registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-24-174342
      startedTime: 2019-01-24T21:53:09Z
      state: Completed
      version: 4.0.0-0.alpha-2019-01-24-174342
    - completionTime: 2019-01-24T21:53:09Z
      image: registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-24-164957
      startedTime: 2019-01-24T21:33:15Z
      state: Completed
      version: 4.0.0-0.alpha-2019-01-24-164957
    - completionTime: 2019-01-24T21:33:15Z
      image: registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-24-174342
      startedTime: 2019-01-24T21:08:55Z
      state: Completed
      version: 4.0.0-0.alpha-2019-01-24-174342
    - completionTime: 2019-01-24T21:08:55Z
      image: registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-24-174342
      startedTime: 2019-01-24T21:08:00Z
      state: Partial
      version: 4.0.0-0.alpha-2019-01-24-174342
    - completionTime: 2019-01-24T21:08:00Z
      image: registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-0.alpha-2019-01-24-164957
      startedTime: 2019-01-24T20:50:58Z
      state: Completed
      version: 4.0.0-0.alpha-2019-01-24-164957
    - completionTime: 2019-01-24T20:50:58Z
      image: registry.svc.ci.openshift.org/openshift/origin-release@sha256:34550de8e9c2c35ed38e6c6e3733051f17d84c8871cf4b673da6106b06d

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 24, 2019
The CVO is reporting history entries back to back that have the same
image and version. Add an integration test to check the status of the
history.
@smarterclayton smarterclayton removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7638aa0 into openshift:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants