Skip to content

Conversation

Leo6Leo
Copy link
Contributor

@Leo6Leo Leo6Leo commented Oct 2, 2025

Description

This PR introduces a feature flag, bridge/impersonate-enable, to gate the new multi-group impersonation feature during its development.

The multi-group impersonation feature is large and will be split into multiple smaller PRs. This flag will keep the feature hidden from users until all frontend and backend components are complete and merged, ensuring we don't expose an incomplete UI.

The flag is disabled by default. A follow up task to remove the feature flag will be opened when the feature is fully tested and ready for GA.

How this work?

// Enable the feature
localStorage.setItem('bridge/impersonate-enabled', 'true'); location.reload();
// Disable the feature
localStorage.setItem('bridge/impersonate-enabled', 'false'); location.reload();

How this will affect the interface you see will be explained in the related PR description.

Note

The number in the PR title specifies the merging order. The larger number means it should be merged after the previous one got merged.

/label tide/merge-method-squash

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2025

@Leo6Leo: This pull request references CONSOLE-4815 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Description

This PR introduces a feature flag, bridge/impersonate-enable, to gate the new multi-group impersonation feature during its development.

The multi-group impersonation feature is large and will be split into multiple smaller PRs. This flag will keep the feature hidden from users until all frontend and backend components are complete and merged, ensuring we don't expose an incomplete UI.

The flag is disabled by default. A follow up task to remove the feature flag will be opened when the feature is fully tested and ready for GA.

How this work?

// Enable the feature
localStorage.setItem('bridge/impersonate-enabled', 'true'); location.reload();
// Disable the feature
localStorage.setItem('bridge/impersonate-enabled', 'false'); location.reload();

How this will affect the interface you see will be explained in the related PR description.

Note

The number in the PR title specifies the merging order. The larger number means it should be merged after the previous one got merged.

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2025
@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 2, 2025
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Oct 2, 2025
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Leo6Leo
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Oct 2, 2025
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@Leo6Leo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console ac7f896 link true /test e2e-gcp-console
ci/prow/okd-scos-e2e-aws-ovn ac7f896 link false /test okd-scos-e2e-aws-ovn
ci/prow/frontend ac7f896 link true /test frontend
ci/prow/images ac7f896 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants