Skip to content

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Sep 25, 2025

AWS EBS CSI driver should support MutableCSINodeAllocatableCount feature.

When the feature gate is enabled:

  • Set CSIDriver nodeAllocatableUpdatePeriodSeconds to 10 minutes, so kubelet knows it should periodically refresh attachment count from the driver.
  • Enable the feature gate in the external-attacher to propagate attach error to the scheduler / KCM.

To be tested together with openshift/api#2502 and after rebase to 1.34. Testing with 1.33 won't harm, but then you need to retest after the rebase...

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2025

@jsafrane: This pull request references STOR-2627 which is a valid jira issue.

In response to this:

AWS EBS CSI driver should support MutableCSINodeAllocatableCount feature.

Set CSIDriver nodeAllocatableUpdatePeriodSeconds to 10 minutes when the feature gate is enabled. Kubelet will then call NodeGetDriverInfo every 10 minutes to update the attach limit of EBS volumes.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2025

@jsafrane: This pull request references STOR-2627 which is a valid jira issue.

In response to this:

AWS EBS CSI driver should support MutableCSINodeAllocatableCount feature.

Set CSIDriver nodeAllocatableUpdatePeriodSeconds to 10 minutes when the feature gate is enabled. Kubelet will then call NodeGetDriverInfo every 10 minutes to update the attach limit of EBS volumes.

To be tested together with openshift/api#2502 and after rebase to 1.34. Testing with 1.33 won't harm, but then you need to retest after the rebase...

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@jsafrane jsafrane force-pushed the add-node-allocatable-sync-interval branch from a8b38c3 to d741e5c Compare September 25, 2025 12:01
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2025

@jsafrane: This pull request references STOR-2627 which is a valid jira issue.

In response to this:

AWS EBS CSI driver should support MutableCSINodeAllocatableCount feature.

When the feature gate is enabled:

  • Set CSIDriver nodeAllocatableUpdatePeriodSeconds to 10 minutes, so kubelet knows it should periodically refresh attachment count from the driver.
  • Enable the feature gate in the external-attacher to propagate attach error to the scheduler / KCM.

To be tested together with openshift/api#2502 and after rebase to 1.34. Testing with 1.33 won't harm, but then you need to retest after the rebase...

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane jsafrane force-pushed the add-node-allocatable-sync-interval branch 3 times, most recently from 82d5a77 to ca7b756 Compare September 25, 2025 13:01
AWS EBS CSI driver should support MutableCSINodeAllocatableCount feature.

Set CSIDriver nodeAllocatableUpdatePeriodSeconds to 10 minutes when the
feature gate is enabled.

Kubelet will then call NodeGetDriverInfo every 10 minutes to update the
attach limit of EBS volumes.
@jsafrane jsafrane force-pushed the add-node-allocatable-sync-interval branch from ca7b756 to 960a598 Compare September 30, 2025 14:02
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/aws-efs-operator-e2e 960a598 link true /test aws-efs-operator-e2e
ci/prow/smb-operator-e2e 960a598 link false /test smb-operator-e2e
ci/prow/okd-scos-e2e-aws-ovn 960a598 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-csi-extended 960a598 link false /test e2e-aws-csi-extended
ci/prow/hypershift-aws-e2e-external 960a598 link true /test hypershift-aws-e2e-external
ci/prow/e2e-aws-ovn-upgrade 960a598 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-csi 960a598 link true /test e2e-aws-csi
ci/prow/e2e-azure 960a598 link true /test e2e-azure
ci/prow/hypershift-e2e-aks 960a598 link true /test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants