-
Notifications
You must be signed in to change notification settings - Fork 46
STOR-2627: Enable nodeAllocatableUpdatePeriodSeconds in AWS EBS #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
STOR-2627: Enable nodeAllocatableUpdatePeriodSeconds in AWS EBS #435
Conversation
@jsafrane: This pull request references STOR-2627 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jsafrane: This pull request references STOR-2627 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a8b38c3
to
d741e5c
Compare
@jsafrane: This pull request references STOR-2627 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
82d5a77
to
ca7b756
Compare
AWS EBS CSI driver should support MutableCSINodeAllocatableCount feature. Set CSIDriver nodeAllocatableUpdatePeriodSeconds to 10 minutes when the feature gate is enabled. Kubelet will then call NodeGetDriverInfo every 10 minutes to update the attach limit of EBS volumes.
ca7b756
to
960a598
Compare
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
AWS EBS CSI driver should support
MutableCSINodeAllocatableCount
feature.When the feature gate is enabled:
nodeAllocatableUpdatePeriodSeconds
to 10 minutes, so kubelet knows it should periodically refresh attachment count from the driver.To be tested together with openshift/api#2502 and after rebase to 1.34. Testing with 1.33 won't harm, but then you need to retest after the rebase...
cc @openshift/storage